VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(core): Path.offset(...) no longer fails on very short curves or zero length paths. Fixes #6519

Browse source
This commit is contained in:
Jonathan Haas 2024-04-08 08:25:09 +02:00
parent 7e694de977
commit 080874dd88
No known key found for this signature in database
GPG key ID: 0E7873037C5924E8
2 changed files with 56 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

31
packages/core/tests/path.test.mjs
View file

@ -118,6 +118,28 @@ describe('Path', () => {
expect(round(bbox.bottomRight.x)).to.equal(119.86)
expect(round(bbox.bottomRight.y)).to.equal(43.49)
})
it('Should offset small curves', () => {
const curve = new Path()
.move(new Point(0, 0))
.curve(new Point(0.1, 0.1), new Point(0.2, 0.2), new Point(0.1, 1.1))
const offset = curve.offset(1)
const bbox = offset.bbox()
expect(round(bbox.bottomRight.x)).to.equal(-0.9)
expect(round(bbox.bottomRight.y)).to.equal(1.19)
})
it('Should offset zero length path', () => {
let logged = false
const log = { warn: () => (logged = true) }
const curve = new Path().__withLog(log).move(new Point(0, 0)).line(new Point(0, 0)).close()
expect(logged).to.equal(false)
const offset = curve.offset(1)
expect(logged).to.equal(true)
const bbox = offset.bbox()
expect(round(bbox.bottomRight.x)).to.equal(0)
expect(round(bbox.bottomRight.y)).to.equal(0)
})
})
describe('length', () => {
@ -354,6 +376,15 @@ describe('Path', () => {
expect(box.bottomRight.y).to.equal(456)
})
it('Should find the bounding box of an empty path', () => {
const path = new Path().move(new Point(123, 456)).close()
const box = path.bbox()
expect(box.topLeft.x).to.equal(123)
expect(box.topLeft.y).to.equal(456)
expect(box.bottomRight.x).to.equal(123)
expect(box.bottomRight.y).to.equal(456)
})
it('Should reverse a path', () => {
const test = new Path()
.move(new Point(123, 456))