VSinerva/freesewing
1
0
Fork 0
Code Activity

wip(core): Work on late-stage config resolver

Browse source 
This moves resolving of the config from the pattern constructor to the
init() method. The idea is that adding a part to a pattern is exactly
the same as adding a part to a design. In other words, late-stage adding
of parts would be no different as the config gets resolved after that.

This is currently broken in many different ways, but the unit tests
particular to this new way of resolving the config do pass.
This commit is contained in:
Joost De Cock 2022-09-09 20:20:38 +02:00
parent 58c15f6c81
commit 0cbffd6dc6
32 changed files with 4536 additions and 3384 deletions
Download patch file Download diff file Expand all files Collapse all files

37
packages/core/src/design.mjs
View file

@ -1,7 +1,6 @@
import { Pattern } from './pattern.mjs'
import { addPartConfig } from './utils.mjs'
/*
* The Design constructor. Returns a Pattern constructor
* So it's sort of a super-constructor
@ -14,43 +13,18 @@ export function Design(config) {
optionalMeasurements: [],
options: {},
parts: [],
data: {},
plugins: [],
// A place to store deprecation and other warnings before we even have a pattern instantiated
events: {
debug: [],
error: [],
info: [],
suggestion: [],
warning: [],
},
...config
}
const raiseEvent = function (data, type) {
config.events[type].push(data)
}
// Polyfill for pattern raise methods
const raise = {
debug: data => raiseEvent(`[early] `+data, 'debug'),
error: data => raiseEvent(`[early] `+data, 'error'),
info: data => raiseEvent(`[early] `+data, 'info'),
suggestion: data => raiseEvent(`[early] `+data, 'suggestion'),
warning: data => raiseEvent(`[early] `+data, 'warning'),
}
const parts = {}
for (const part of config.parts) {
if (typeof part === 'object') {
parts[part.name] = part
config = addPartConfig(parts[part.name], config, raise )
}
else throw("Invalid part configuration. Part is not an object")
}
// Replace config.parts with the resolved config
config.parts = parts
// Create the pattern constructor
const pattern = function (settings) {
// Pass the design config
Pattern.call(this, config)
return this.init().apply(settings)
// Pass the pattern settings
return this.__applySettings(settings)
}
// Set up inheritance
@ -62,4 +36,3 @@ export function Design(config) {
return pattern
}