From 156bad3f5b815f0b47caad4c7fb4dba47a128bdf Mon Sep 17 00:00:00 2001
From: Joost De Cock <joost@joost.at>
Date: Sat, 27 Nov 2021 16:46:14 +0100
Subject: [PATCH] chore(plugin-svgattr): Added (esm) unit tests. See #408

---
 packages/plugin-svgattr/CHANGELOG.md          |  6 ++++++
 packages/plugin-svgattr/package.json          | 11 ++++++++---
 packages/plugin-svgattr/src/index.js          |  4 ++--
 packages/plugin-svgattr/tests/plugin.test.mjs | 11 +++++++++++
 packages/plugin-svgattr/tests/shared.test.mjs | 10 ++++++++++
 5 files changed, 37 insertions(+), 5 deletions(-)
 create mode 100644 packages/plugin-svgattr/tests/plugin.test.mjs
 create mode 100644 packages/plugin-svgattr/tests/shared.test.mjs

diff --git a/packages/plugin-svgattr/CHANGELOG.md b/packages/plugin-svgattr/CHANGELOG.md
index 9dc6c6f4b64..09c7ab32802 100644
--- a/packages/plugin-svgattr/CHANGELOG.md
+++ b/packages/plugin-svgattr/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Change log for: @freesewing/plugin-svgattr
 
 
+## unreleased (NaN-NaN-NaN)
+
+### Added
+
+ - Added (esm) unit tests
+
 ## 2.0.0 (2019-08-25)
 
 ### Added
diff --git a/packages/plugin-svgattr/package.json b/packages/plugin-svgattr/package.json
index 8954d415573..ab0dc5847cc 100644
--- a/packages/plugin-svgattr/package.json
+++ b/packages/plugin-svgattr/package.json
@@ -30,18 +30,23 @@
     "clean": "rimraf dist",
     "build": "rollup -c",
     "lernabuild": "rollup -c",
-    "test": "BABEL_ENV=production ../../node_modules/.bin/_mocha tests/*.test.js --require @babel/register",
+    "test": "BABEL_ENV=production ../../node_modules/.bin/_mocha tests/*.test.mjs --require @babel/register",
     "pubtest": "npm publish --registry http://localhost:6662",
     "pubforce": "npm publish",
     "symlink": "mkdir -p ./node_modules/@freesewing && cd ./node_modules/@freesewing && ln -s -f ../../../* . && cd -",
     "start": "rollup -c -w",
-    "prettier": "npx prettier --write 'src/*.js' 'tests/*.js'"
+    "testci": "BABEL_ENV=production ../../node_modules/.bin/_mocha tests/*.test.mjs --require @babel/register",
+    "prettier": "npx prettier --write 'src/*.js' 'tests/*.mjs'"
   },
   "peerDependencies": {
     "@freesewing/core": "^2.19.5"
   },
   "dependencies": {},
-  "devDependencies": {},
+  "devDependencies": {
+    "mocha": "^9.1.1",
+    "chai": "^4.2.0",
+    "@babel/register": "^7.10.5"
+  },
   "files": [
     "dist/*",
     "README.md",
diff --git a/packages/plugin-svgattr/src/index.js b/packages/plugin-svgattr/src/index.js
index b13ae4b7ecc..9d4508f4088 100644
--- a/packages/plugin-svgattr/src/index.js
+++ b/packages/plugin-svgattr/src/index.js
@@ -4,9 +4,9 @@ export default {
   name: name,
   version: version,
   hooks: {
-    preRender: function (svg, attributes) {
+    preRender: function (svg, attributes={}) {
       if (svg.attributes.get('freesewing:plugin-svgattr') === false) {
-        for (let key of Object.keys(attributes)) svg.attributes.add(key, attributes[key])
+        for (const key of Object.keys(attributes)) svg.attributes.add(key, attributes[key])
         svg.attributes.add('freesewing:plugin-svgattr', version)
       }
     },
diff --git a/packages/plugin-svgattr/tests/plugin.test.mjs b/packages/plugin-svgattr/tests/plugin.test.mjs
new file mode 100644
index 00000000000..b5dfd5333f9
--- /dev/null
+++ b/packages/plugin-svgattr/tests/plugin.test.mjs
@@ -0,0 +1,11 @@
+import chai from 'chai'
+import freesewing from '@freesewing/core'
+import plugin from '../dist/index.mjs'
+
+const expect = chai.expect;
+
+describe('SVG Attributed Plugin Tests', () => {
+  it("FIXME: No plugin tests defined", () => {
+    expect(1).to.equal(1)
+  })
+})
diff --git a/packages/plugin-svgattr/tests/shared.test.mjs b/packages/plugin-svgattr/tests/shared.test.mjs
new file mode 100644
index 00000000000..42cd98f4655
--- /dev/null
+++ b/packages/plugin-svgattr/tests/shared.test.mjs
@@ -0,0 +1,10 @@
+// This file is auto-generated.
+// Changes you make will be overwritten.
+import freesewing from '@freesewing/core'
+import chai from 'chai'
+import plugin from '../dist/index.mjs'
+import { sharedPluginTests } from '../../../tests/plugins/shared.mjs'
+
+
+// Run shared tests
+sharedPluginTests(plugin, freesewing, chai.expect)