From 5e6c32b2f2d878e49bfd1d96b7c1d462861e1d72 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Mon, 9 Sep 2019 12:06:04 +0200 Subject: [PATCH 1/3] Update index.js --- packages/utils/src/measurementDiffers/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/utils/src/measurementDiffers/index.js b/packages/utils/src/measurementDiffers/index.js index 92b6bf75695..ba5827c4286 100644 --- a/packages/utils/src/measurementDiffers/index.js +++ b/packages/utils/src/measurementDiffers/index.js @@ -1,6 +1,9 @@ import neckstimate from '../neckstimate' // This returns how many sizes a measurement differs from the neckstimate value +// 0 and 2 is great +// 2 to 5 is hmmm +// and above 5 is probably wrong const measurementDiffers = ( neckCircumference, measurementName, From 76cc7405dd178d23219eda9cbf631d1f0b72230f Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Tue, 10 Sep 2019 09:44:22 +0200 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=90=9E=20Fix=20measurementDiffers=20t?= =?UTF-8?q?o=20crash=20with=20breasts?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/utils/src/measurementDiffers/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utils/src/measurementDiffers/index.js b/packages/utils/src/measurementDiffers/index.js index ba5827c4286..0c948e0ecfe 100644 --- a/packages/utils/src/measurementDiffers/index.js +++ b/packages/utils/src/measurementDiffers/index.js @@ -9,6 +9,6 @@ const measurementDiffers = ( measurementName, measurementValue, breasts = false -) => Math.abs(Math.round((measurementValue - neckstimate(neckCircumference, measurementName)) / 20)) +) => Math.abs(Math.round((measurementValue - neckstimate(neckCircumference, measurementName, breasts)) / 20)) export default measurementDiffers From 2c6a399696e361fde3b366c9022a0a1dc523b213 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Tue, 10 Sep 2019 09:47:07 +0200 Subject: [PATCH 3/3] Update changelog.yaml --- config/changelog.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/changelog.yaml b/config/changelog.yaml index 270d1320b67..7d89e2bff3d 100644 --- a/config/changelog.yaml +++ b/config/changelog.yaml @@ -5,6 +5,8 @@ Unreleased: Deprecated: Removed: Fixed: + utils: + - Fix measurementDiffers to crash with breasts Security: 2.0.2: