VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(react): Pattern Layout print settings UI fixes (#351)

Browse source 
Fixes #341
Fixes #342

![Screenshot 2025-05-13 at 4.19.07 PM.png](/attachments/495b1a64-b7e6-40ca-b531-287cea0d29a1)
![Screenshot 2025-05-13 at 4.18.47 PM.png](/attachments/ce8f568e-537e-4f19-b0c1-893253966914)

Co-authored-by: Benjamin Fan <ben-git@swinglonga.com>
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/351
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Benjamin Fan <benjamesben@noreply.codeberg.org>
Co-committed-by: Benjamin Fan <benjamesben@noreply.codeberg.org>
This commit is contained in:
Benjamin Fan 2025-05-18 09:40:11 +00:00 • committed by Joost De Cock
parent dcf7c0412b
commit 3390def67c
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/react/components/Editor/components/menus/Value.mjs
View file

@ -119,7 +119,7 @@ export const MenuMmValue = ({ current, config, units, changed }) => (
* Displays the current percentage value, and the absolute value if configured * Displays the current percentage value, and the absolute value if configured
*/ */
export const MenuPctOptionValue = ({ config, current, settings, changed, patternConfig }) => { export const MenuPctOptionValue = ({ config, current, settings, changed, patternConfig }) => {
const val = changed ? current : config.pct / 100 const val = changed ? current : config.dflt
return ( return (
<MenuHighlightValue changed={changed}> <MenuHighlightValue changed={changed}>

8
packages/react/components/Editor/lib/layout-settings.mjs
View file

@ -20,7 +20,8 @@ const defaultPrintSettings = (units) => ({
size: units === 'imperial' ? 'letter' : 'a4', size: units === 'imperial' ? 'letter' : 'a4',
orientation: 'portrait', orientation: 'portrait',
margin: units === 'imperial' ? 12.7 : 10, margin: units === 'imperial' ? 12.7 : 10,
coverPage: true, coverPage: 1,
iconSize: 0.5,
}) })
export function menuLayoutSettingsStructure(units) { export function menuLayoutSettingsStructure(units) {
@ -76,6 +77,7 @@ export function menuLayoutSettingsStructure(units) {
), ),
}, },
icon: PageOrientationIcon, icon: PageOrientationIcon,
dflt: defaults.orientation,
}, },
margin: { margin: {
dense: true, dense: true,
@ -98,7 +100,7 @@ export function menuLayoutSettingsStructure(units) {
0: 'Do not include a cover page', 0: 'Do not include a cover page',
1: 'Include a cover page', 1: 'Include a cover page',
}, },
dflt: 0, dflt: defaults.coverPage,
}, },
iconSize: { iconSize: {
dense: true, dense: true,
@ -108,7 +110,7 @@ export function menuLayoutSettingsStructure(units) {
about: about:
'Controls the size of the icons that allow you to rotate/flip individual pattern parts', 'Controls the size of the icons that allow you to rotate/flip individual pattern parts',
min: 10, min: 10,
dflt: 0.5, dflt: defaults.iconSize,
step: 1, step: 1,
max: 200, max: 200,
}, },