VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(simon): Check that the cfHips-notch is available before updating it

Browse source 
This notch is not available in Simone, which caused it to break under
certain configurations.

Fixes [#833](https://github.com/freesewing/freesewing.org/issues/833)
This commit is contained in:
Joost De Cock 2020-07-23 12:50:01 +02:00
parent ab15690d9c
commit 44f84ff3a0
2 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/simon/src/buttonholeplacket.js
View file

@ -1,6 +1,6 @@
import { addButtonHoles } from './shared'
export default part => {
export default (part) => {
let {
utils,
sa,
@ -61,11 +61,7 @@ export default part => {
.split(points.topInnerEdge)[0]
.line(points.bottomInnerEdge)
paths.seam = paths.saBase
.clone()
.line(points.placketBottomEdge)
.close()
.attr('class', 'fabric')
paths.seam = paths.saBase.clone().line(points.placketBottomEdge).close().attr('class', 'fabric')
// Complete pattern?
if (complete) {
@ -98,7 +94,9 @@ export default part => {
// Notches
snippets['cfArmhole-notch'].anchor.x = points.cfArmhole.x - fold * 2
snippets['cfWaist-notch'].anchor.x = points.cfArmhole.x - fold * 2
snippets['cfHips-notch'].anchor.x = points.cfArmhole.x - fold * 2
// This notch is not available in Simone
if (typeof snippets['cfHips-notch'] !== 'undefined')
snippets['cfHips-notch'].anchor.x = points.cfArmhole.x - fold * 2
// Buttons
addButtonHoles(part, 'placketCfNeck')