1
0
Fork 0

fix(simon): Check that the cfHips-notch is available before updating it

This notch is not available in Simone, which caused it to break under
certain configurations.

Fixes [#833](https://github.com/freesewing/freesewing.org/issues/833)
This commit is contained in:
Joost De Cock 2020-07-23 12:50:01 +02:00
parent ab15690d9c
commit 44f84ff3a0
2 changed files with 9 additions and 7 deletions

View file

@ -13,6 +13,9 @@ Unreleased:
- Added backend calls for creating gists/issues on Github - Added backend calls for creating gists/issues on Github
wahid: wahid:
- Added the `square` hem style. Fixes [#672](https://github.com/freesewing/freesewing.org/issues/672) - Added the `square` hem style. Fixes [#672](https://github.com/freesewing/freesewing.org/issues/672)
Changed:
wahid:
- Hem radius can no longer be zero. Use teh `square` hem style for that
Fixed: Fixed:
aaron: aaron:
- Set missing option `brianFitCollar` to `false` - Set missing option `brianFitCollar` to `false`
@ -25,6 +28,7 @@ Unreleased:
- Adding missing control point to front neck opening - Adding missing control point to front neck opening
simon: simon:
- Set missing option `brianFitCollar` to `false` - Set missing option `brianFitCollar` to `false`
- Don't assume the `chHips-notch` is available because it's not in Simone. Fixes [#833](https://github.com/freesewing/freesewing.org/issues/833)
simone: simone:
- Set missing option `brianFitCollar` to `false` - Set missing option `brianFitCollar` to `false`
sven: sven:

View file

@ -1,6 +1,6 @@
import { addButtonHoles } from './shared' import { addButtonHoles } from './shared'
export default part => { export default (part) => {
let { let {
utils, utils,
sa, sa,
@ -61,11 +61,7 @@ export default part => {
.split(points.topInnerEdge)[0] .split(points.topInnerEdge)[0]
.line(points.bottomInnerEdge) .line(points.bottomInnerEdge)
paths.seam = paths.saBase paths.seam = paths.saBase.clone().line(points.placketBottomEdge).close().attr('class', 'fabric')
.clone()
.line(points.placketBottomEdge)
.close()
.attr('class', 'fabric')
// Complete pattern? // Complete pattern?
if (complete) { if (complete) {
@ -98,7 +94,9 @@ export default part => {
// Notches // Notches
snippets['cfArmhole-notch'].anchor.x = points.cfArmhole.x - fold * 2 snippets['cfArmhole-notch'].anchor.x = points.cfArmhole.x - fold * 2
snippets['cfWaist-notch'].anchor.x = points.cfArmhole.x - fold * 2 snippets['cfWaist-notch'].anchor.x = points.cfArmhole.x - fold * 2
snippets['cfHips-notch'].anchor.x = points.cfArmhole.x - fold * 2 // This notch is not available in Simone
if (typeof snippets['cfHips-notch'] !== 'undefined')
snippets['cfHips-notch'].anchor.x = points.cfArmhole.x - fold * 2
// Buttons // Buttons
addButtonHoles(part, 'placketCfNeck') addButtonHoles(part, 'placketCfNeck')