fix(simon): Check that the cfHips-notch
is available before updating it
This notch is not available in Simone, which caused it to break under certain configurations. Fixes [#833](https://github.com/freesewing/freesewing.org/issues/833)
This commit is contained in:
parent
ab15690d9c
commit
44f84ff3a0
2 changed files with 9 additions and 7 deletions
|
@ -13,6 +13,9 @@ Unreleased:
|
|||
- Added backend calls for creating gists/issues on Github
|
||||
wahid:
|
||||
- Added the `square` hem style. Fixes [#672](https://github.com/freesewing/freesewing.org/issues/672)
|
||||
Changed:
|
||||
wahid:
|
||||
- Hem radius can no longer be zero. Use teh `square` hem style for that
|
||||
Fixed:
|
||||
aaron:
|
||||
- Set missing option `brianFitCollar` to `false`
|
||||
|
@ -25,6 +28,7 @@ Unreleased:
|
|||
- Adding missing control point to front neck opening
|
||||
simon:
|
||||
- Set missing option `brianFitCollar` to `false`
|
||||
- Don't assume the `chHips-notch` is available because it's not in Simone. Fixes [#833](https://github.com/freesewing/freesewing.org/issues/833)
|
||||
simone:
|
||||
- Set missing option `brianFitCollar` to `false`
|
||||
sven:
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
import { addButtonHoles } from './shared'
|
||||
|
||||
export default part => {
|
||||
export default (part) => {
|
||||
let {
|
||||
utils,
|
||||
sa,
|
||||
|
@ -61,11 +61,7 @@ export default part => {
|
|||
.split(points.topInnerEdge)[0]
|
||||
.line(points.bottomInnerEdge)
|
||||
|
||||
paths.seam = paths.saBase
|
||||
.clone()
|
||||
.line(points.placketBottomEdge)
|
||||
.close()
|
||||
.attr('class', 'fabric')
|
||||
paths.seam = paths.saBase.clone().line(points.placketBottomEdge).close().attr('class', 'fabric')
|
||||
|
||||
// Complete pattern?
|
||||
if (complete) {
|
||||
|
@ -98,6 +94,8 @@ export default part => {
|
|||
// Notches
|
||||
snippets['cfArmhole-notch'].anchor.x = points.cfArmhole.x - fold * 2
|
||||
snippets['cfWaist-notch'].anchor.x = points.cfArmhole.x - fold * 2
|
||||
// This notch is not available in Simone
|
||||
if (typeof snippets['cfHips-notch'] !== 'undefined')
|
||||
snippets['cfHips-notch'].anchor.x = points.cfArmhole.x - fold * 2
|
||||
|
||||
// Buttons
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue