VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(brian): Make s3 options snap to zero below 10%. Closes #2249

Browse source
This commit is contained in:
Joost De Cock 2022-07-09 16:39:21 +02:00
parent b21d75f745
commit 46d9f19e7b
3 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
config/changelog.yaml
View file

@ -7,6 +7,11 @@ Unreleased:
theo: theo:
- migrated `waistbandWidth` option from `mm` to snapped `pct` option - migrated `waistbandWidth` option from `mm` to snapped `pct` option
Fixed:
brian:
- Make s3 options sticky to zero below 10% to avoid path split issues.
Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249)
2.21.3: 2.21.3:
date: 2022-07-02 date: 2022-07-02

6
designs/brian/src/back.js
View file

@ -20,7 +20,8 @@ export default (part) => {
// Adapt the shoulder seam according to the relevant options // Adapt the shoulder seam according to the relevant options
// Note: s3 stands for Shoulder Seam Shift // Note: s3 stands for Shoulder Seam Shift
if (options.s3Collar === 0) { // Don't bother with less than 10% as that's just asking for trouble
if (options.s3Collar < 0.1 && options.s3Collar > -0.1) {
points.s3CollarSplit = points.hps points.s3CollarSplit = points.hps
paths.backCollar = new Path() paths.backCollar = new Path()
.move(points.hps) .move(points.hps)
@ -58,7 +59,8 @@ export default (part) => {
.reverse() .reverse()
.setRender(false) .setRender(false)
} }
if (options.s3Armhole === 0) { // Don't bother with less than 10% as that's just asking for trouble
if (options.s3Armhole < 0.1 && options.s3Armhole > -0.1) {
points.s3ArmholeSplit = points.shoulder points.s3ArmholeSplit = points.shoulder
paths.backArmhole = new Path() paths.backArmhole = new Path()
.move(points.armholePitch) .move(points.armholePitch)

5
designs/brian/src/front.js
View file

@ -23,7 +23,8 @@ export default (part) => {
points.armholePitchCp2 = points.frontArmholePitchCp2 points.armholePitchCp2 = points.frontArmholePitchCp2
// Adapt the shoulder line according to the relevant options // Adapt the shoulder line according to the relevant options
if (options.s3Collar === 0) { // Don't bother with less than 10% as that's just asking for trouble
if (options.s3Collar < 0.1 && options.s3Collar > -0.1) {
points.s3CollarSplit = points.hps points.s3CollarSplit = points.hps
paths.frontCollar = new Path() paths.frontCollar = new Path()
.move(points.hps) .move(points.hps)
@ -60,7 +61,7 @@ export default (part) => {
.join(new Path().move(points.hps).curve(points.neckCp2Front, points.cfNeckCp1, points.cfNeck)) .join(new Path().move(points.hps).curve(points.neckCp2Front, points.cfNeckCp1, points.cfNeck))
.setRender(false) .setRender(false)
} }
if (options.s3Armhole === 0) { if (options.s3Armhole < 0.1 && options.s3Armhole > -0.1) {
points.s3ArmholeSplit = points.shoulder points.s3ArmholeSplit = points.shoulder
paths.frontArmhole = new Path() paths.frontArmhole = new Path()
.move(points.armholePitch) .move(points.armholePitch)