From 5cfa9df28794c18bc1a92dfc6ddb355f61943b30 Mon Sep 17 00:00:00 2001
From: joostdecock <joost@joost.at>
Date: Mon, 28 Apr 2025 07:16:39 +0200
Subject: [PATCH] [react] fix: Button state for boolean core options. Fixes
 #229

---
 .../components/Editor/components/HeaderMenu.mjs  | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/packages/react/components/Editor/components/HeaderMenu.mjs b/packages/react/components/Editor/components/HeaderMenu.mjs
index 0d36c9470c7..e8a931f36ca 100644
--- a/packages/react/components/Editor/components/HeaderMenu.mjs
+++ b/packages/react/components/Editor/components/HeaderMenu.mjs
@@ -312,19 +312,27 @@ export const HeaderMenuDraftViewIcons = (props) => {
       {ux >= levels.complete ? (
         <Button
           lgOnly
-          updateHandler={() => update.settings('complete', settings.complete ? 0 : 1)}
+          updateHandler={() =>
+            update.settings('complete', [false, 0, '0'].includes(settings.complete) ? 1 : 0)
+          }
           tooltip="Turns Details on or off (see Core Settings)"
         >
-          <DetailIcon className={`${size} ${!settings.complete ? 'tw:text-secondary' : muted}`} />
+          <DetailIcon
+            className={`${size} ${[false, 0, '0'].includes(settings.complete) ? 'tw:text-secondary' : muted}`}
+          />
         </Button>
       ) : null}
       {ux >= levels.expand ? (
         <Button
           lgOnly
-          updateHandler={() => update.settings('expand', settings.expand ? 0 : 1)}
+          updateHandler={() =>
+            update.settings('expand', [false, 0, '0'].includes(settings.expand) ? 1 : 0)
+          }
           tooltip="Turns Expand on or off (see Core Settings)"
         >
-          <ExpandIcon className={`${size} ${settings.expand ? 'tw:text-secondary' : muted}`} />
+          <ExpandIcon
+            className={`${size} ${[false, 0, '0'].includes(settings.expand) ? 'tw:text-secondary' : muted}`}
+          />
         </Button>
       ) : null}
       <HeaderMenuIconSpacer />