fix(simon): Handle boxpleat issue in yoke. Fixes #2400
This commit is contained in:
parent
686d1d6304
commit
634b4fe7b8
4 changed files with 11 additions and 1 deletions
|
@ -33,6 +33,12 @@
|
||||||
|
|
||||||
- Fix hem allowance. Closes [#2350](https://github.com/freesewing/freesewing/issues/2350)
|
- Fix hem allowance. Closes [#2350](https://github.com/freesewing/freesewing/issues/2350)
|
||||||
|
|
||||||
|
### simon
|
||||||
|
|
||||||
|
#### Fixed
|
||||||
|
|
||||||
|
- Fix issue with boxPleat and yoke Fixes [#2400](https://github.com/freesewing/freesewing/issues/2400)
|
||||||
|
|
||||||
### simone
|
### simone
|
||||||
|
|
||||||
#### Fixed
|
#### Fixed
|
||||||
|
|
|
@ -20,6 +20,9 @@ Unreleased:
|
||||||
brian:
|
brian:
|
||||||
- Make s3 options sticky to zero below 10% to avoid path split issues.
|
- Make s3 options sticky to zero below 10% to avoid path split issues.
|
||||||
Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249)
|
Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249)
|
||||||
|
simon:
|
||||||
|
- Fix issue with boxPleat and yoke
|
||||||
|
Fixes [#2400](https://github.com/freesewing/freesewing/issues/2400)
|
||||||
simone:
|
simone:
|
||||||
- Don't do a negative FBA from there's no need for an FBA
|
- Don't do a negative FBA from there's no need for an FBA
|
||||||
Fixes [#2121](https://github.com/freesewing/freesewing/issues/2121)
|
Fixes [#2121](https://github.com/freesewing/freesewing/issues/2121)
|
||||||
|
|
|
@ -129,6 +129,7 @@ export default (part) => {
|
||||||
} else points.cbTop = points.cbYoke
|
} else points.cbTop = points.cbYoke
|
||||||
|
|
||||||
// Box pleat
|
// Box pleat
|
||||||
|
points.armholeYokeSplitPreBoxpleat = points.armholeYokeSplit.clone()
|
||||||
if (options.boxPleat) {
|
if (options.boxPleat) {
|
||||||
points.boxPleatLeft = points.cbTop.shift(0, store.get('boxPleatWidth') / 2)
|
points.boxPleatLeft = points.cbTop.shift(0, store.get('boxPleatWidth') / 2)
|
||||||
points.boxPleatMid = points.boxPleatLeft.shift(0, store.get('boxPleatFold'))
|
points.boxPleatMid = points.boxPleatLeft.shift(0, store.get('boxPleatFold'))
|
||||||
|
|
|
@ -7,7 +7,7 @@ export default (part) => {
|
||||||
}
|
}
|
||||||
|
|
||||||
// Paths
|
// Paths
|
||||||
paths.saBase = new Path().move(points.cbYoke).line(points.armholeYokeSplit)
|
paths.saBase = new Path().move(points.cbYoke).line(points.armholeYokeSplitPreBoxpleat)
|
||||||
if (options.yokeHeight > 0) paths.saBase = paths.saBase.join(paths.backArmholeYoke)
|
if (options.yokeHeight > 0) paths.saBase = paths.saBase.join(paths.backArmholeYoke)
|
||||||
paths.saBase = paths.saBase.line(points.s3CollarSplit).join(paths.backCollar)
|
paths.saBase = paths.saBase.line(points.s3CollarSplit).join(paths.backCollar)
|
||||||
if (options.splitYoke) paths.saBase = paths.saBase.line(points.cbYoke).close()
|
if (options.splitYoke) paths.saBase = paths.saBase.line(points.cbYoke).close()
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue