From 71c559807fa4459407c0fb373d8d7ff19063ed72 Mon Sep 17 00:00:00 2001
From: joostdecock <joost@joost.at>
Date: Thu, 17 Aug 2023 20:02:46 +0200
Subject: [PATCH] chore: Linter issues

---
 sites/backend/src/config.mjs                    | 6 ++----
 sites/backend/src/models/admin.mjs              | 3 +--
 sites/backend/src/models/flow.mjs               | 2 +-
 sites/org/components/github/create-showcase.mjs | 6 +++---
 sites/org/components/github/inputs.mjs          | 5 ++---
 sites/shared/components/account/role.mjs        | 6 ------
 sites/shared/components/account/status.mjs      | 2 --
 sites/shared/components/admin.mjs               | 7 ++-----
 sites/shared/components/code-box.mjs            | 1 -
 sites/shared/components/wrappers/auth/index.mjs | 5 ++---
 10 files changed, 13 insertions(+), 30 deletions(-)

diff --git a/sites/backend/src/config.mjs b/sites/backend/src/config.mjs
index 8bfa8bc86ae..686fdc56f23 100644
--- a/sites/backend/src/config.mjs
+++ b/sites/backend/src/config.mjs
@@ -182,13 +182,11 @@ if (baseConfig.use.cloudflareImages) {
 }
 
 // FowardMx config
-if (baseConfig.use.fowardmx) {
-  const account = process.env.BACKEND_CLOUDFLARE_ACCOUNT || 'fixmeSetCloudflareAccountId'
+if (baseConfig.use.fowardmx)
   baseConfig.forwardmx = {
     key: process.env.BACKEND_FORWARDMX_KEY || 'fixmeSetFowardMxApiKey',
     useInTests: baseConfig.use.tests.fowardmx,
   }
-}
 
 // AWS SES config (for sending out emails)
 if (baseConfig.use.ses)
@@ -231,7 +229,7 @@ const config = postConfig(baseConfig)
 
 // Exporting this stand-alone config
 export const cloudflareImages = config.cloudflareImages || {}
-export const fowardmx = config.fowardmx || {}
+export const forwardmx = config.forwardmx || {}
 export const website = config.website
 export const githubToken = config.github.token
 
diff --git a/sites/backend/src/models/admin.mjs b/sites/backend/src/models/admin.mjs
index e7a41f76de3..7b57330d6b9 100644
--- a/sites/backend/src/models/admin.mjs
+++ b/sites/backend/src/models/admin.mjs
@@ -1,4 +1,3 @@
-import { log } from '../utils/log.mjs'
 import { decorateModel } from '../utils/model-decorator.mjs'
 
 /*
@@ -123,7 +122,7 @@ AdminModel.prototype.updateUser = async function ({ params, body, user }) {
   /*
    * Disable MFA?
    */
-  if (body.mfaEnabled && body.mfaEnabled === false) {
+  if (typeof body.mfaEnabled !== 'undefined' && body.mfaEnabled === false) {
     data.mfaEnabled = false
     data.mfaSecret = ''
   }
diff --git a/sites/backend/src/models/flow.mjs b/sites/backend/src/models/flow.mjs
index 871dd496a15..b4fd06771ee 100644
--- a/sites/backend/src/models/flow.mjs
+++ b/sites/backend/src/models/flow.mjs
@@ -160,7 +160,7 @@ FlowModel.prototype.uploadImage = async function ({ body, user }) {
    * Prepare data for uploading the image
    */
   const data = {
-    id: `${body.type}-${body.slug}${body.subId && body.subId !== 'main' ? '-' + body.subId : ''}`,
+    id: `${body.type}-${body.slug}${body.subId !== 'main' ? '-' + body.subId : ''}`,
     metadata: { uploadedBy: user.uid },
   }
   if (body.img) data.b64 = body.img
diff --git a/sites/org/components/github/create-showcase.mjs b/sites/org/components/github/create-showcase.mjs
index 926e701cdcf..311730378de 100644
--- a/sites/org/components/github/create-showcase.mjs
+++ b/sites/org/components/github/create-showcase.mjs
@@ -1,7 +1,7 @@
 // Dependencies
 import { nsMerge, capitalize, cloudflareImageUrl, yyyymmdd } from 'shared/utils.mjs'
 // Hooks
-import { useState } from 'react'
+import { useState, Fragment } from 'react'
 import { useAccount } from 'shared/hooks/use-account.mjs'
 import { useBackend } from 'shared/hooks/use-backend.mjs'
 import { useTranslation } from 'next-i18next'
@@ -436,7 +436,7 @@ const ShowcaseEditor = ({
               cloudflareImageUrl({ id: extraImages[key], variant: 'public' }) +
               ' "The image caption/title goes here")'
             return (
-              <>
+              <Fragment key={key}>
                 <ImageInput
                   key={key}
                   setImg={(img) => setExtraImg(key, img)}
@@ -459,7 +459,7 @@ const ShowcaseEditor = ({
                     </p>
                   </>
                 )}
-              </>
+              </Fragment>
             )
           })}
           <button className="btn btn-secondary mt-2" onClick={addImage}>
diff --git a/sites/org/components/github/inputs.mjs b/sites/org/components/github/inputs.mjs
index bc3e8bcecd3..03070d06af0 100644
--- a/sites/org/components/github/inputs.mjs
+++ b/sites/org/components/github/inputs.mjs
@@ -35,9 +35,8 @@ export const BodyInput = ({ body, setBody }) => (
     placeholder="Type your post body here"
     onChange={(evt) => setBody(evt.target.value)}
     rows={16}
-  >
-    {body}
-  </textarea>
+    value={body}
+  />
 )
 
 export const TitleInput = ({ title, setTitle }) => (
diff --git a/sites/shared/components/account/role.mjs b/sites/shared/components/account/role.mjs
index 525281ca9ff..e0391325c08 100644
--- a/sites/shared/components/account/role.mjs
+++ b/sites/shared/components/account/role.mjs
@@ -1,10 +1,5 @@
-import { roles as rolesConfig } from 'config/roles.mjs'
-import { useTranslation } from 'next-i18next'
-
 export const ns = ['roles']
 
-const roles = Object.keys(rolesConfig.levels)
-
 const colors = {
   user: 'primary',
   curator: 'secondary',
@@ -14,7 +9,6 @@ const colors = {
 }
 
 export const AccountRole = ({ role }) => {
-  const { t } = useTranslation()
   const color = colors[role]
 
   return (
diff --git a/sites/shared/components/account/status.mjs b/sites/shared/components/account/status.mjs
index e9f597b5099..cfc9d623d16 100644
--- a/sites/shared/components/account/status.mjs
+++ b/sites/shared/components/account/status.mjs
@@ -1,10 +1,8 @@
-import { useTranslation } from 'next-i18next'
 import { freeSewingConfig } from 'shared/config/freesewing.config.mjs'
 
 export const ns = ['status']
 
 export const AccountStatus = ({ status }) => {
-  const { t } = useTranslation()
   const { name, color } = freeSewingConfig.statuses[status]
 
   return (
diff --git a/sites/shared/components/admin.mjs b/sites/shared/components/admin.mjs
index b3fd0c8b80d..c0690dd49a3 100644
--- a/sites/shared/components/admin.mjs
+++ b/sites/shared/components/admin.mjs
@@ -3,13 +3,9 @@ import { cloudflareConfig } from 'shared/config/cloudflare.mjs'
 import { useBackend } from 'shared/hooks/use-backend.mjs'
 import { useAccount } from 'shared/hooks/use-account.mjs'
 import { useToast } from 'shared/hooks/use-toast.mjs'
-import { formatNumber } from 'shared/utils.mjs'
 import Link from 'next/link'
 import Markdown from 'react-markdown'
 
-import { Popout } from 'shared/components/popout/index.mjs'
-import { Collapse } from 'shared/components/collapse.mjs'
-import { Spinner } from 'shared/components/spinner.mjs'
 import { Json } from 'shared/components/json.mjs'
 import { AccountRole } from 'shared/components/account/role.mjs'
 import { AccountStatus } from 'shared/components/account/status.mjs'
@@ -48,7 +44,7 @@ export const Row = ({ title, val }) => (
   </tr>
 )
 
-export const Hits = ({ results, t }) => (
+export const Hits = ({ results }) => (
   <>
     {results && results.username && results.username.length > 0 && (
       <>
@@ -184,6 +180,7 @@ export const ManageUser = ({ userId }) => {
         )}
         {Object.keys(freeSewingConfig.statuses).map((status) => (
           <button
+            key={status}
             className="btn btn-warning btn-outline btn-sm"
             onClick={() => updateUser({ status })}
             disabled={Number(status) === user.status}
diff --git a/sites/shared/components/code-box.mjs b/sites/shared/components/code-box.mjs
index 6d4f5e638c7..833123d169b 100644
--- a/sites/shared/components/code-box.mjs
+++ b/sites/shared/components/code-box.mjs
@@ -1,4 +1,3 @@
-import { CopyIcon } from 'shared/components/icons.mjs'
 import { CopyToClipboard } from 'shared/components/copy-to-clipboard.mjs'
 
 export const CodeBox = ({ code, title }) => (
diff --git a/sites/shared/components/wrappers/auth/index.mjs b/sites/shared/components/wrappers/auth/index.mjs
index 7f10339913d..0757f7cef57 100644
--- a/sites/shared/components/wrappers/auth/index.mjs
+++ b/sites/shared/components/wrappers/auth/index.mjs
@@ -102,7 +102,7 @@ const ConsentLacking = ({ t, banner }) => (
   </Wrap>
 )
 
-export const AuthWrapper = ({ children, app, requiredRole = 'user' }) => {
+export const AuthWrapper = ({ children, requiredRole = 'user' }) => {
   const { t } = useTranslation(ns)
   const { account, token, admin, stopImpersonating, signOut } = useAccount()
   const backend = useBackend()
@@ -125,8 +125,7 @@ export const AuthWrapper = ({ children, app, requiredRole = 'user' }) => {
     }
     const verifyUser = async () => {
       const result = await backend.ping()
-      if (result.success) {
-      } else signOut()
+      if (!result.success) signOut()
     }
     if (admin && admin.token) verifyAdmin()
     if (token) verifyUser()