From 7ef9198fe8331d05cb8d9d33c3e1e4b29ab182f3 Mon Sep 17 00:00:00 2001
From: joostdecock <joost@joost.at>
Date: Sun, 27 Aug 2023 17:01:58 +0200
Subject: [PATCH] chore(shared): Linter issues

---
 sites/shared/components/account/sets.mjs      | 23 ++++++++-----------
 .../workbench/menus/shared/index.mjs          |  6 ++---
 .../workbench/menus/shared/inputs.mjs         |  2 +-
 .../workbench/menus/shared/menu-item.mjs      | 12 +++++-----
 .../components/workbench/views/draft/menu.mjs |  2 +-
 .../components/workbench/views/test/menu.mjs  | 23 +++++++++++--------
 6 files changed, 33 insertions(+), 35 deletions(-)

diff --git a/sites/shared/components/account/sets.mjs b/sites/shared/components/account/sets.mjs
index 5ff0dada22d..2bbf0bb9252 100644
--- a/sites/shared/components/account/sets.mjs
+++ b/sites/shared/components/account/sets.mjs
@@ -110,14 +110,13 @@ export const MeasieVal = ({ val, m, imperial }) =>
 
 export const MsetCard = ({
   set,
-  control,
   onClick = false,
   href = false,
   useA = false,
   design = false,
   language = false,
 }) => {
-  const { t, i18n } = useTranslation(ns)
+  const { t } = useTranslation(ns)
 
   const wrapperProps = {
     className:
@@ -134,11 +133,7 @@ export const MsetCard = ({
 
   let note = <span></span>
   if (design) {
-    const [hasMeasies, missingMeasies] = hasRequiredMeasurements(
-      designMeasurements[design],
-      set.measies,
-      true
-    )
+    const [hasMeasies] = hasRequiredMeasurements(designMeasurements[design], set.measies, true)
     const noteClasses =
       'bg-opacity-90 w-full text-center py-2 font-bold px-2 rounded rounded-b-none leading-4 text-sm'
     note = hasMeasies ? (
@@ -730,7 +725,6 @@ export const Sets = () => {
 
 export const SetCard = ({
   set,
-  language,
   requiredMeasies = [],
   href = false,
   onClick = false,
@@ -739,7 +733,7 @@ export const SetCard = ({
   // Hooks
   const { t } = useTranslation(['sets'])
 
-  const [hasMeasies, missingMeasies] = hasRequiredMeasurements(requiredMeasies, set.measies, true)
+  const [hasMeasies] = hasRequiredMeasurements(requiredMeasies, set.measies, true)
 
   const wrapperProps = {
     className:
@@ -756,7 +750,7 @@ export const SetCard = ({
   const inner = hasMeasies ? null : (
     <div className="flex flex-row gap-2 items-center">
       <WarningIcon className="w-6 h-6 shrink-0 text-error" />
-      <span>{t('setLacksMeasiesForDesign', { design: t(`designs:${design}.t`) })}</span>
+      <span>{t('setLacksMeasiesForDesign')}</span>
     </div>
   )
 
@@ -819,7 +813,7 @@ export const UserSetPicker = ({ design, t, href, clickHandler }) => {
   if (Object.keys(sets).length > 0) {
     hasSets = true
     for (const setId in sets) {
-      const [hasMeasies, missingMeasies] = hasRequiredMeasurements(
+      const [hasMeasies] = hasRequiredMeasurements(
         designMeasurements[design],
         sets[setId].measies,
         true
@@ -875,7 +869,7 @@ export const UserSetPicker = ({ design, t, href, clickHandler }) => {
         <>
           <h4>{t('account:theseSetsReady')}</h4>
           <div className="grid grid-cols-1 md:grid-cols-2 2xl:grid-cols-3 gap-2">
-            {okSets.map((set, i) => (
+            {okSets.map((set) => (
               <MsetButton
                 {...{ set, control, design }}
                 onClick={clickHandler}
@@ -890,7 +884,7 @@ export const UserSetPicker = ({ design, t, href, clickHandler }) => {
         <div className="my-4">
           <h4>{t('account:someSetsLacking')}</h4>
           <div className="grid grid-cols-1 md:grid-cols-2 2xl:grid-cols-3 gap-2">
-            {lackingSets.map((set, i) => (
+            {lackingSets.map((set) => (
               <MsetLink
                 {...{ set, control, design }}
                 onClick={clickHandler}
@@ -998,6 +992,7 @@ export const CuratedSetPicker = ({ design, language, href, clickHandler }) => {
           <MsetButton
             key={set.id}
             {...{ set, control, design }}
+            href={href}
             onClick={clickHandler}
             requiredMeasies={measurements[design]}
             language={i18n.language}
@@ -1008,7 +1003,7 @@ export const CuratedSetPicker = ({ design, language, href, clickHandler }) => {
   )
 }
 
-export const BookmarkedSetPicker = ({ t }) => <V3Wip />
+export const BookmarkedSetPicker = () => <V3Wip />
 
 export const SetPicker = ({ design, href = false, clickHandler = false }) => {
   const { t, i18n } = useTranslation('sets')
diff --git a/sites/shared/components/workbench/menus/shared/index.mjs b/sites/shared/components/workbench/menus/shared/index.mjs
index fd6add544d3..0bd5233715d 100644
--- a/sites/shared/components/workbench/menus/shared/index.mjs
+++ b/sites/shared/components/workbench/menus/shared/index.mjs
@@ -53,7 +53,7 @@ export const WorkbenchMenu = ({
   updateFunc,
   ns,
   Icon = () => null,
-  name,
+  //name,
   config,
   control,
   inputs,
@@ -65,9 +65,9 @@ export const WorkbenchMenu = ({
   language,
   emojis,
   Item,
-  isFirst,
+  //isFirst,
   children,
-  docsPath,
+  //docsPath,
   isDesignOptionsGroup,
 }) => {
   // get translation for the menu
diff --git a/sites/shared/components/workbench/menus/shared/inputs.mjs b/sites/shared/components/workbench/menus/shared/inputs.mjs
index c86c6e8c8a3..f9c7f8fa023 100644
--- a/sites/shared/components/workbench/menus/shared/inputs.mjs
+++ b/sites/shared/components/workbench/menus/shared/inputs.mjs
@@ -477,7 +477,7 @@ export const ConstantInput = ({
   name,
   current,
   updateFunc,
-  t,
+  //t,
   changed,
   config,
 }) => (
diff --git a/sites/shared/components/workbench/menus/shared/menu-item.mjs b/sites/shared/components/workbench/menus/shared/menu-item.mjs
index 9d14c274e79..78f8b4dc9af 100644
--- a/sites/shared/components/workbench/menus/shared/menu-item.mjs
+++ b/sites/shared/components/workbench/menus/shared/menu-item.mjs
@@ -62,11 +62,11 @@ export const MenuItem = ({
   t,
   passProps = {},
   changed,
-  loadDocs,
+  //loadDocs,
   Input = () => {},
-  Value = () => {},
+  //Value = () => {},
   allowOverride = false,
-  allowToggle = false,
+  //allowToggle = false,
   control = Infinity,
   DynamicDocs,
   docsPath,
@@ -113,7 +113,7 @@ export const MenuItem = ({
         />
       </button>
     )
-  const ResetButton = ({ open, disabled = false }) => (
+  const ResetButton = ({ disabled = false }) => (
     <button
       className={`${iconButtonClass} disabled:bg-opacity-0`}
       disabled={disabled}
@@ -171,7 +171,7 @@ export const MenuItem = ({
 export const MenuItemGroup = ({
   collapsible = true,
   control,
-  name,
+  //name,
   currentValues = {},
   structure,
   Icon,
@@ -201,7 +201,7 @@ export const MenuItemGroup = ({
       ? GroupIcon
       : Icon
       ? Icon
-      : () => <span role="img">{emoji}</span>
+      : () => <span role="img">fixme-icon</span>
     const Value = item.isGroup
       ? () => (
           <div className="flex flex-row gap-2 items-center font-medium">
diff --git a/sites/shared/components/workbench/views/draft/menu.mjs b/sites/shared/components/workbench/views/draft/menu.mjs
index 89f97e686d0..53003763f21 100644
--- a/sites/shared/components/workbench/views/draft/menu.mjs
+++ b/sites/shared/components/workbench/views/draft/menu.mjs
@@ -17,7 +17,7 @@ export const ns = nsMerge(coreMenuNs, designMenuNs, uiNs)
 export const DraftMenu = ({
   design,
   patternConfig,
-  setSettings,
+  //setSettings,
   settings,
   ui,
   update,
diff --git a/sites/shared/components/workbench/views/test/menu.mjs b/sites/shared/components/workbench/views/test/menu.mjs
index 8f8092f48c4..ccb2db79f70 100644
--- a/sites/shared/components/workbench/views/test/menu.mjs
+++ b/sites/shared/components/workbench/views/test/menu.mjs
@@ -1,3 +1,4 @@
+import { Fragment } from 'react'
 import { ns as optionsNs } from './options.mjs'
 import { ns as measieNs } from './measurements.mjs'
 import { Accordion } from 'shared/components/accordion.mjs'
@@ -30,9 +31,9 @@ export const TestMenu = ({
   patternConfig,
   settings,
   update,
-  language,
-  account,
-  DynamicDocs,
+  //language,
+  //account,
+  //DynamicDocs,
 }) => {
   const { t } = useTranslation(ns)
 
@@ -50,7 +51,8 @@ export const TestMenu = ({
             <p>{t('workbench:testOptionsDesc')}</p>
           </>,
           <ListInput
-            list={[...allOptions].map((option) => ({
+            list={[...allOptions].map((option, i) => ({
+              key: i,
               label: [
                 ...option.path.map((p) => (
                   <>
@@ -58,7 +60,7 @@ export const TestMenu = ({
                     {spacer}
                   </>
                 )),
-                <span>{t(`${design}:${option.key}.t`)}</span>,
+                <span key={1}>{t(`${design}:${option.key}.t`)}</span>,
               ],
               val: option.key,
             }))}
@@ -70,14 +72,15 @@ export const TestMenu = ({
           />,
         ],
         [
-          <>
+          <Fragment key="a">
             <h5 className="flex flex-row gap-2 items-center justify-between w-full">
               <span>{t('workbench:testMeasurements')}</span>
               <MeasieIcon className="w-8 h-8" />
             </h5>
             <p>{t('workbench:testOptionsDesc')}</p>
-          </>,
+          </Fragment>,
           <ListInput
+            key="b"
             list={patternConfig.measurements.map((m) => ({
               label: t(m),
               val: m,
@@ -90,14 +93,14 @@ export const TestMenu = ({
           />,
         ],
         [
-          <>
+          <Fragment key="a">
             <h5 className="flex flex-row gap-2 items-center justify-between w-full">
               <span>{t('workbench:testSets')}</span>
               <CommunityIcon className="w-8 h-8" />
             </h5>
             <p>{t('workbench:testSetsDesc')}</p>
-          </>,
-          <V3Wip />,
+          </Fragment>,
+          <V3Wip key="b" />,
         ],
       ]}
     />