1
0
Fork 0

Merge pull request #2548 from BenJamesBen/2545-cathrin-seam-allowance

fix (cathrin): Remove seam allowance from Part1a foldline. Fixes #2545
This commit is contained in:
Joost De Cock 2022-08-09 20:47:40 +02:00 committed by GitHub
commit 8c3aa9a9ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 7 deletions

View file

@ -3,6 +3,12 @@
## Unreleased ## Unreleased
### aaron
#### Added
- Support drafting for high bust
### breanna ### breanna
#### Fixed #### Fixed
@ -15,11 +21,11 @@
- Make s3 options sticky to zero below 10% to avoid path split issues. Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249) - Make s3 options sticky to zero below 10% to avoid path split issues. Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249)
### aaron ### cathrin
#### Added #### Fixed
- Support drafting for high bust - Removed seam allowance from Part1a foldline. Fixes [#2545](https://github.com/freesewing/freesewing/issues/2545)
### charlie ### charlie

View file

@ -24,6 +24,9 @@ Unreleased:
brian: brian:
- Make s3 options sticky to zero below 10% to avoid path split issues. - Make s3 options sticky to zero below 10% to avoid path split issues.
Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249) Fixes [#2249](https://github.com/freesewing/freesewing/issues/2249)
cathrin:
- Removed seam allowance from Part1a foldline.
Fixes [#2545](https://github.com/freesewing/freesewing/issues/2545)
simon: simon:
- Fix issue with boxPleat and yoke - Fix issue with boxPleat and yoke
Fixes [#2400](https://github.com/freesewing/freesewing/issues/2400) Fixes [#2400](https://github.com/freesewing/freesewing/issues/2400)

View file

@ -12,13 +12,16 @@ export default function (part) {
.curve(paths.panel1.ops[1].cp1, paths.panel1.ops[1].cp2, paths.panel1.ops[1].to) .curve(paths.panel1.ops[1].cp1, paths.panel1.ops[1].cp2, paths.panel1.ops[1].to)
points.bottomABsplit = bottom.shiftFractionAlong(0.3) points.bottomABsplit = bottom.shiftFractionAlong(0.3)
paths.panel1a = bottom paths.panel1a_nonfold = new Path()
.split(points.bottomABsplit)[0] .move(points.bottomCF)
.join(bottom.split(points.bottomABsplit)[0])
.line(points.topABsplit) .line(points.topABsplit)
.join(top.split(points.topABsplit)[1]) .join(top.split(points.topABsplit)[1])
.line(points.bottomCF) .setRender(false)
paths.panel1a = paths.panel1a_nonfold.clone()
.close() .close()
.attr('class', 'fabric') .attr('class', 'fabric')
.setRender(true)
paths.panel1b = bottom paths.panel1b = bottom
.split(points.bottomABsplit)[1] .split(points.bottomABsplit)[1]
.curve(points.hipsGap1Cp, points.waistGap1LeftCp1, points.waistGap1Left) .curve(points.hipsGap1Cp, points.waistGap1LeftCp1, points.waistGap1Left)
@ -35,7 +38,11 @@ export default function (part) {
// Complete pattern? // Complete pattern?
if (complete) { if (complete) {
if (sa) { if (sa) {
paths.saA = paths.panel1a.offset(sa).attr('class', 'fabric sa') paths.saA = paths.panel1a_nonfold.offset(sa).attr('class', 'fabric sa')
paths.saA
.line(points.topCF)
.move(points.bottomCF)
.line(paths.saA.start())
paths.saB = paths.panel1b.offset(sa).attr('class', 'fabric sa') paths.saB = paths.panel1b.offset(sa).attr('class', 'fabric sa')
} }
macro('cutonfold', { macro('cutonfold', {