From 96ee31b11059d47002456d4031a8afce51e2a161 Mon Sep 17 00:00:00 2001 From: joostdecock Date: Sun, 31 Jul 2022 12:28:21 +0200 Subject: [PATCH] fix(plugin-grainline): Check for complete before adding output --- plugins/plugin-grainline/src/index.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/plugins/plugin-grainline/src/index.js b/plugins/plugin-grainline/src/index.js index eac1e46d5a5..422019bfdc9 100644 --- a/plugins/plugin-grainline/src/index.js +++ b/plugins/plugin-grainline/src/index.js @@ -29,18 +29,20 @@ export default { ...dflts, ...so, } - let points = this.points + const { points, complete } = this.shorthand() this.setGrain(so.from.angle(so.to)) - points.grainlineFrom = so.from.shiftFractionTowards(so.to, 0.05) - points.grainlineTo = so.to.shiftFractionTowards(so.from, 0.05) - this.paths.grainline = new this.Path() - .move(points.grainlineFrom) - .line(points.grainlineTo) - .attr('class', 'note') - .attr('marker-start', 'url(#grainlineFrom)') - .attr('marker-end', 'url(#grainlineTo)') - .attr('data-text', so.text) - .attr('data-text-class', 'center fill-note') + if (complete) { + points.grainlineFrom = so.from.shiftFractionTowards(so.to, 0.05) + points.grainlineTo = so.to.shiftFractionTowards(so.from, 0.05) + this.paths.grainline = new this.Path() + .move(points.grainlineFrom) + .line(points.grainlineTo) + .attr('class', 'note') + .attr('marker-start', 'url(#grainlineFrom)') + .attr('marker-end', 'url(#grainlineTo)') + .attr('data-text', so.text) + .attr('data-text-class', 'center fill-note') + } }, }, }