VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(plugin-bartack): Linter warnings

Browse source
This commit is contained in:
Joost De Cock 2021-04-18 13:16:37 +02:00
parent 4a5cdcdb32
commit 97e88c9d57
1 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
packages/plugin-bartack/src/bartack.js
View file

@ -1,6 +1,6 @@
const name = (n, so) => `${so.prefix}${n}${so.suffix}` const name = (n, so) => `${so.prefix}${n}${so.suffix}`
const drawBartack = (points, so, self) => { const drawBartack = (points, self) => {
let path = new self.Path().move(points.path1[0]) let path = new self.Path().move(points.path1[0])
for (let i in points.path1) { for (let i in points.path1) {
if (points.path1[i]) path = path.line(points.path1[i]) if (points.path1[i]) path = path.line(points.path1[i])
@ -10,27 +10,25 @@ const drawBartack = (points, so, self) => {
return path return path
} }
const getPoints = (path, so, self) => { const getPoints = (path, so) => {
let path1 = path.offset(so.width / 2) let path1 = path.offset(so.width / 2)
let path2 = path.offset(so.width / -2) let path2 = path.offset(so.width / -2)
let len1 = path1.length() let len = path1.length()
let len2 = path2.length() let len2 = path2.length()
// Make sure path1 is always the longest one // Make sure path1 is always the longest one
if (len2 > len1) { if (len2 > len) {
let tmp = path2 let tmp = path2
path2 = path1 path2 = path1
path1 = tmp path1 = tmp
tmp = len2 len = len2
len2 = len1
len1 = tmp
} }
let points = { let points = {
path1: [path1.start()], path1: [path1.start()],
path2: [path2.start()] path2: [path2.start()]
} }
let steps = Math.ceil((len1 / so.width) * so.density) let steps = Math.ceil((len / so.width) * so.density)
for (let i = 1; i < steps; i++) { for (let i = 1; i < steps; i++) {
points.path1.push(path1.shiftFractionAlong((1 / steps) * i)) points.path1.push(path1.shiftFractionAlong((1 / steps) * i))
points.path2.push(path2.shiftFractionAlong((1 / steps) * i)) points.path2.push(path2.shiftFractionAlong((1 / steps) * i))
@ -39,8 +37,7 @@ const getPoints = (path, so, self) => {
return points return points
} }
const bartackPath = (path, so, self) => const bartackPath = (path, so, self) => (path ? drawBartack(getPoints(path, so), self) : null)
path ? drawBartack(getPoints(path, so, self), so, self) : null
export default function bartack(so, self) { export default function bartack(so, self) {
const defaults = { const defaults = {
@ -75,7 +72,7 @@ export default function bartack(so, self) {
let end = false let end = false
if (so.bartackAlong) { if (so.bartackAlong) {
if (so.start > 0) start = so.path.shiftAlong(so.start) if (so.start > 0) start = so.path.shiftAlong(so.start)
if (end < so.path.length) end = so.path.shiftAlong(so.end) if (!end || end < so.path.length) end = so.path.shiftAlong(so.end)
} else if (so.bartackFractionAlong) { } else if (so.bartackFractionAlong) {
if (so.start > 0) start = so.path.shiftFractionAlong(so.start) if (so.start > 0) start = so.path.shiftFractionAlong(so.start)
if (so.end < 1) end = so.path.shiftFractionAlong(so.end) if (so.end < 1) end = so.path.shiftFractionAlong(so.end)