From aa2d236f7ac20547daf26a7495936f6be66c7a66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vili=20Sinerv=C3=A4?= Date: Sat, 4 May 2024 01:30:30 +0300 Subject: [PATCH] Fix drafting error by converting vent count to number before comparing --- designs/jaeger/src/back.mjs | 13 +++++++------ designs/jaeger/src/side.mjs | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/designs/jaeger/src/back.mjs b/designs/jaeger/src/back.mjs index b3743c5b600..68072678a87 100644 --- a/designs/jaeger/src/back.mjs +++ b/designs/jaeger/src/back.mjs @@ -18,7 +18,7 @@ function jaegerBack({ }) { // Back vent(s) const ventY = points.cbHips.y - points.cbWaistCp2.dy(points.cbHips) * options.backVentLength - if (options.backVent === 1) { + if (Number(options.backVent) === 1) { // Single back vent // Vent tip points.ventStart = utils.curveIntersectsY( @@ -44,7 +44,7 @@ function jaegerBack({ points.cbWaistCp2, points.cbWaist ) - } else if (options.backVent === 2) { + } else if (Number(options.backVent) === 2) { // Double back vent // Vent tip points.ventStart = utils.curveIntersectsY( @@ -80,7 +80,7 @@ function jaegerBack({ for (let i of Object.keys(snippets)) delete snippets[i] // Paths - if (options.backVent === 2) { + if (Number(options.backVent) === 2) { paths.saBase = paths.vent .clone() .reverse() @@ -109,7 +109,7 @@ function jaegerBack({ paths.saBase = paths.saBase._curve(points.cbChestCp1, points.cbChest) else paths.saBase = paths.saBase.line(points.cbChest) paths.saBase = paths.saBase.curve(points.cbChestCp2, points.cbWaistCp1, points.cbWaist) - if (options.backVent === 1) { + if (Number(options.backVent) === 1) { paths.saBase = paths.saBase .join( new Path() @@ -126,8 +126,9 @@ function jaegerBack({ } paths.saBase.hide() - if (options.backVent === 2) paths.hemBase = new Path().move(points.cbHem).line(paths.vent.end()) - else if (options.backVent === 1) + if (Number(options.backVent) === 2) + paths.hemBase = new Path().move(points.cbHem).line(paths.vent.end()) + else if (Number(options.backVent) === 1) paths.hemBase = new Path().move(paths.vent.end()).line(points.hem) else paths.hemBase = new Path().move(points.cbHem).line(points.hem) paths.hemBase.hide() diff --git a/designs/jaeger/src/side.mjs b/designs/jaeger/src/side.mjs index 2c814fcb4be..81424b1da55 100644 --- a/designs/jaeger/src/side.mjs +++ b/designs/jaeger/src/side.mjs @@ -17,7 +17,7 @@ function jaegerSide({ part, }) { // Double back vent - if (options.backVent === 2) { + if (Number(options.backVent) === 2) { let ventY = points.bsHips.y - points.bsWaistCp1.dy(points.bsHips) * options.backVentLength // Vent tip points.ventStart = utils.curveIntersectsY( @@ -57,7 +57,7 @@ function jaegerSide({ // Paths paths.hemBase = new Path().move(points.sideHem).line(points.bsHem) - if (options.backVent === 2) { + if (Number(options.backVent === 2)) { paths.hemBase.line(points.ventHem).line(paths.vent.end()) paths.saBase = paths.vent .clone()