From b714d9af1f7ecca5c494823d373140770454561d Mon Sep 17 00:00:00 2001 From: Joost De Cock Date: Wed, 29 Jun 2022 12:59:31 +0200 Subject: [PATCH] fix(config-helpers): Guard against missing measurements --- config/changelog.yaml | 4 +++- packages/config-helpers/src/index.js | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/config/changelog.yaml b/config/changelog.yaml index e6c411b1887..8770fba179e 100644 --- a/config/changelog.yaml +++ b/config/changelog.yaml @@ -1,5 +1,7 @@ Unreleased: - Added: + Fixed: + config-helpers: + - Guard against missing measurements in toAbs() 2.21.1: date: 2022-06-28 diff --git a/packages/config-helpers/src/index.js b/packages/config-helpers/src/index.js index 6e1d03e7376..085d5b8254e 100644 --- a/packages/config-helpers/src/index.js +++ b/packages/config-helpers/src/index.js @@ -44,8 +44,12 @@ export const bigsteps = { */ export function pctBasedOn(measurement) { return { - toAbs: (val, { measurements }) => measurements[measurement] * val, - fromAbs: (val, { measurements }) => Math.round((10 * val) / measurements[measurement]) / 10, + toAbs: (val, { measurements }) => measurements?.[measurement] + ? measurements[measurement] * val + : null, + fromAbs: (val, { measurements }) => measurements?.[measurement] + ? Math.round((10 * val) / measurements[measurement]) / 10 + : null } }