From bd11ed683acda62caa8913d2e687dc8e7a6e3d2c Mon Sep 17 00:00:00 2001 From: woutervdub Date: Wed, 20 Dec 2023 04:56:47 +0000 Subject: [PATCH] Change some defaults, and fix a bug. --- designs/lumira/src/shape.mjs | 4 ++-- designs/lumira/src/waistband.mjs | 2 +- markdown/org/docs/designs/lumira/fabric/en.md | 4 +++- markdown/org/docs/designs/lumira/instructions/en.md | 2 +- markdown/org/docs/designs/lumira/options/ease/en.md | 8 +++++++- 5 files changed, 14 insertions(+), 6 deletions(-) diff --git a/designs/lumira/src/shape.mjs b/designs/lumira/src/shape.mjs index 1beeb9f45fa..a9543605a52 100644 --- a/designs/lumira/src/shape.mjs +++ b/designs/lumira/src/shape.mjs @@ -155,9 +155,9 @@ export const shape = { }, // Percentages - ease: { pct: -5, min: -30, max: 0, menu: 'fit' }, + ease: { pct: -8, min: -30, max: 0, menu: 'fit' }, leglength: { pct: 100, min: 10, max: 100, ...pctBasedOn('inseam'), menu: 'style' }, - waistlowering: { pct: 10, min: -10, max: 60, ...pctBasedOn('waistToHips'), menu: 'style' }, + waistlowering: { pct: 35, min: -10, max: 60, ...pctBasedOn('waistToHips'), menu: 'style' }, gussetwidth: { pct: 16, min: 5, diff --git a/designs/lumira/src/waistband.mjs b/designs/lumira/src/waistband.mjs index d24f37357e1..4c93bd0efa3 100644 --- a/designs/lumira/src/waistband.mjs +++ b/designs/lumira/src/waistband.mjs @@ -26,7 +26,7 @@ export const waistband = { const waistLength = store.get('waistLength') const waistbandSize = store.get('waistbandSize') - const gussetWidth = options.frontbulge ? store.get('gussetWidth') : 0 + const gussetWidth = options.frontbulge || options.cyclingchamois ? store.get('gussetWidth') : 0 const topLength = points.backWaist.dist(points.frontWaist) const bottomLength = waistLength + gussetWidth diff --git a/markdown/org/docs/designs/lumira/fabric/en.md b/markdown/org/docs/designs/lumira/fabric/en.md index 4c27f93880e..093a863a0d4 100644 --- a/markdown/org/docs/designs/lumira/fabric/en.md +++ b/markdown/org/docs/designs/lumira/fabric/en.md @@ -6,7 +6,9 @@ title: "Lumira leggings: Fabric Options" This pattern requires a stretch fabric. The stretch needs to be perpendicular to the grainline. There is no stretch required along the grainline, but a 4-way stretch fabric can definitely be used. Not all stretch fabrics have the same amount of stretch. The default -ease value of -5% works well for fabrics that have 60% stretch. If your fabric has a different amount of stretch, you may want to adjust this setting accordingly. +ease value of -5% works well for fabrics that have 60% stretch. If your fabric has a different amount of stretch, you may want to +adjust this setting accordingly. Reduce the ease when your fabric has more stretch. Getting the ease right is *very* important for +getting a good fit. These fabrics come in different weights. Pick one that works for how you intent to use it. Thicker fabrics provide more support and warmth. diff --git a/markdown/org/docs/designs/lumira/instructions/en.md b/markdown/org/docs/designs/lumira/instructions/en.md index 33dbec2d0fe..26030bb32fc 100644 --- a/markdown/org/docs/designs/lumira/instructions/en.md +++ b/markdown/org/docs/designs/lumira/instructions/en.md @@ -14,7 +14,7 @@ provide a zigzag in addition to serging the seam. ### Step 1: The waistband (optional) -- Sew the two pieces to eachother, right sides together, along the top seam. +- Sew the two pieces to each other, right sides together, along the top seam. - Press the seam open - Sew the back seam, right sides together. This creates a loop. diff --git a/markdown/org/docs/designs/lumira/options/ease/en.md b/markdown/org/docs/designs/lumira/options/ease/en.md index 4ae9e35b387..82657ea23df 100644 --- a/markdown/org/docs/designs/lumira/options/ease/en.md +++ b/markdown/org/docs/designs/lumira/options/ease/en.md @@ -5,5 +5,11 @@ title: "Ease" *** Controls the amount of ease build into the pattern. Since these are leggings that are to be made of stretch fabric, -the ease is nagative. So the completed garment will be narrower than the measurements would dictate. +the ease is nagative. So the completed garment will be narower than the measurements would dictate. + + +Getting the wease right for your type of fabric is essential for getting a good fit. If you make the ease +too negative, the leggings will be too constricting, and limiting movement. If you don't make the ease +negative enough, the leggings will not hug your legs and torso. The fabric should be stretched in all +places, without being too tight.