VSinerva/freesewing
1
0
Fork 0
Code Activity

✨ Throw only errors

Browse source
This commit is contained in:
Joost De Cock 2018-12-29 12:56:09 +01:00
parent 198d442879
commit cc6d52dfb6
2 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/path.js
View file

@ -312,7 +312,7 @@ function joinPaths(paths, closed = false) {
// We're using sitsRoughlyOn here to avoid miniscule line segments
if (current && !op.to.sitsRoughlyOn(current)) joint.line(op.to);
} else {
throw "Cannot join a closed paths with another";
throw new Error("Cannot join a closed paths with another");
}
if (op.to) current = op.to;
}
@ -347,7 +347,7 @@ Path.prototype.shiftAlong = function(distance) {
}
current = op.to;
}
throw "Ran out of path to shift along";
throw new Error("Ran out of path to shift along");
};
/** Returns a point that lies at fraction along this */
@ -554,7 +554,7 @@ Path.prototype.intersectsY = function(y) {
/** Finds intersections between this path and a X or Y value */
Path.prototype.intersectsAxis = function(val = false, mode) {
if (val === false)
throw "Path.intersects[X-Y] requires an value as parameter";
throw new Error("Path.intersects[X-Y] requires an value as parameter");
let intersections = [];
let lineStart =
mode === "x" ? new Point(val, -100000) : new Point(-10000, val);
@ -586,7 +586,9 @@ Path.prototype.intersectsAxis = function(val = false, mode) {
/** Finds intersections between this path and another path */
Path.prototype.intersects = function(path) {
if (this === path)
throw "Calculating intersections between two identical paths is bad idea";
throw new Error(
"Calculating intersections between two identical paths is bad idea"
);
let intersections = [];
for (let pathA of this.divide()) {
for (let pathB of path.divide()) {

7
src/pattern.js
View file

@ -59,7 +59,7 @@ export default function Pattern(config = { options: {} }) {
this.settings.options[i] = option.bool;
else if (typeof option.dflt !== "undefined")
this.settings.options[i] = option.dflt;
else throw "Unknown option type";
else throw new Error("Unknown option type: " + JSON.stringify(option));
} else {
this.settings.options[i] = option;
}
@ -276,7 +276,10 @@ Pattern.prototype.sampleMeasurement = function(measurementName) {
let anchors = {};
let parts = this.sampleParts();
let val = this.settings.measurements[measurementName];
if (val === undefined) throw "Cannot sample a measurement that is undefined";
if (val === undefined)
throw new Error(
"Cannot sample a measurement that is undefined: " + measurementName
);
let step = val / 50;
val = val * 0.9;
for (let run = 1; run < 11; run++) {