VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(backend): 404 errors do not use a result string

Browse source
This commit is contained in:
Benjamin Fan 2024-08-28 10:35:02 -07:00
parent 85214486b5
commit d25dd0a4ea
8 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sites/backend/src/controllers/apikeys.mjs
View file

@ -27,7 +27,7 @@ ApikeysController.prototype.list = async (req, res, tools) => {
const apikeys = await Apikey.userApikeys(req.user.uid) const apikeys = await Apikey.userApikeys(req.user.uid)
if (apikeys) Apikey.setResponse(200, 'success', { apikeys }) if (apikeys) Apikey.setResponse(200, 'success', { apikeys })
else Apikey.setResponse(404, 'notFound') else Apikey.setResponse(404)
return Apikey.sendResponse(res) return Apikey.sendResponse(res)
} }
@ -71,7 +71,7 @@ ApikeysController.prototype.whoami = async (req, res, tools) => {
userId: key[0].userId, userId: key[0].userId,
}, },
}) })
else Apikey.setResponse(404, 'notFound') else Apikey.setResponse(404)
return Apikey.sendResponse(res) return Apikey.sendResponse(res)
} }

2
sites/backend/src/controllers/bookmarks.mjs
View file

@ -33,7 +33,7 @@ BookmarksController.prototype.list = async (req, res, tools) => {
const bookmarks = await Bookmark.userBookmarks(req.user.uid) const bookmarks = await Bookmark.userBookmarks(req.user.uid)
if (bookmarks) Bookmark.setResponse(200, 'success', { bookmarks }) if (bookmarks) Bookmark.setResponse(200, 'success', { bookmarks })
else Bookmark.setResponse(404, 'notFound') else Bookmark.setResponse(404)
return Bookmark.sendResponse(res) return Bookmark.sendResponse(res)
} }

2
sites/backend/src/controllers/curated-sets.mjs
View file

@ -36,7 +36,7 @@ CuratedSetsController.prototype.list = async (req, res, tools, format = false) =
if (curatedSets) { if (curatedSets) {
if (!format) CuratedSet.setResponse(200, 'success', { curatedSets }) if (!format) CuratedSet.setResponse(200, 'success', { curatedSets })
else CuratedSet.setResponse(200, 'success', curatedSets, true) else CuratedSet.setResponse(200, 'success', curatedSets, true)
} else CuratedSet.setResponse(404, 'notFound') } else CuratedSet.setResponse(404)
return format === 'yaml' && curatedSets return format === 'yaml' && curatedSets
? CuratedSet.sendYamlResponse(res) ? CuratedSet.sendYamlResponse(res)

2
sites/backend/src/controllers/option-packs.mjs
View file

@ -35,7 +35,7 @@ OptionPacksController.prototype.list = async (req, res, tools, format = false) =
if (optionPacks) { if (optionPacks) {
if (!format) OptionPack.setResponse(200, 'success', { optionPacks }) if (!format) OptionPack.setResponse(200, 'success', { optionPacks })
else OptionPack.setResponse(200, 'success', optionPacks, true) else OptionPack.setResponse(200, 'success', optionPacks, true)
} else OptionPack.setResponse(404, 'notFound') } else OptionPack.setResponse(404)
return format === 'yaml' && optionPacks return format === 'yaml' && optionPacks
? OptionPack.sendYamlResponse(res) ? OptionPack.sendYamlResponse(res)

2
sites/backend/src/controllers/patterns.mjs
View file

@ -11,7 +11,7 @@ PatternsController.prototype.list = async (req, res, tools) => {
const patterns = await Pattern.userPatterns(req.user.uid) const patterns = await Pattern.userPatterns(req.user.uid)
if (patterns) Pattern.setResponse(200, 'success', { patterns }) if (patterns) Pattern.setResponse(200, 'success', { patterns })
else Pattern.setResponse(404, 'notFound') else Pattern.setResponse(404)
return Pattern.sendResponse(res) return Pattern.sendResponse(res)
} }

2
sites/backend/src/controllers/sets.mjs
View file

@ -33,7 +33,7 @@ SetsController.prototype.list = async (req, res, tools) => {
const sets = await Set.userSets(req.user.uid) const sets = await Set.userSets(req.user.uid)
if (sets) Set.setResponse(200, 'success', { sets }) if (sets) Set.setResponse(200, 'success', { sets })
else Set.setResponse(404, 'notFound') else Set.setResponse(404)
return Set.sendResponse(res) return Set.sendResponse(res)
} }

2
sites/backend/src/models/pattern.mjs
View file

@ -182,7 +182,7 @@ PatternModel.prototype.guardedRead = async function ({ params, user }) {
/* /*
* Return 404 if it cannot be found * Return 404 if it cannot be found
*/ */
if (!this.record) return this.setResponse(404, 'notFound') if (!this.record) return this.setResponse(404)
/* /*
* You need at least the bughunter role to read another user's pattern * You need at least the bughunter role to read another user's pattern

2
sites/backend/src/models/subscriber.mjs
View file

@ -240,7 +240,7 @@ SubscriberModel.prototype.verifySubscription = async function (body) {
/* /*
* If it is not found, return 404 * If it is not found, return 404
*/ */
if (!this.record) return this.setResponse(404, 'subscriberNotFound') if (!this.record) return this.setResponse(404)
return this return this
} }