VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(core): Typo in option distance comparison. Fixes #2742

Browse source
This commit is contained in:
Joost De Cock 2022-09-29 14:31:02 +02:00
parent 4ad7183b1b
commit d380cc1259
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/core/src/pattern.mjs
View file

@ -463,13 +463,12 @@ Pattern.prototype.__addPartOptions = function (part) {
if (part.options) { if (part.options) {
for (const optionName in part.options) { for (const optionName in part.options) {
if (!this.__mutated.optionDistance[optionName]) { if (!this.__mutated.optionDistance[optionName]) {
this.__mutated.optionDistance[optionName] = this.__mutated.partDistance?.[part.name] || 0
this.__mutated.optionDistance[optionName] = this.__mutated.partDistance?.[part.name] || 0 this.__mutated.optionDistance[optionName] = this.__mutated.partDistance?.[part.name] || 0
// Keep design parts immutable in the pattern or risk subtle bugs // Keep design parts immutable in the pattern or risk subtle bugs
this.config.options[optionName] = Object.freeze(part.options[optionName]) this.config.options[optionName] = Object.freeze(part.options[optionName])
this.store.log.debug(`🔵 __${optionName}__ option loaded from part \`${part.name}\``) this.store.log.debug(`🔵 __${optionName}__ option loaded from part \`${part.name}\``)
} else if ( } else if (
this.__mutated.optionDistance[optionName] > this.__mutated.partDistance[part.name] this.__mutated.optionDistance[optionName] < this.__mutated.partDistance[part.name]
) { ) {
this.config.options[optionName] = part.options[optionName] this.config.options[optionName] = part.options[optionName]
this.store.log.debug(`🟣 __${optionName}__ option overwritten by \`${part.name}\``) this.store.log.debug(`🟣 __${optionName}__ option overwritten by \`${part.name}\``)