VSinerva/freesewing
1
0
Fork 0
Code Activity

Merge pull request #6002 from freesewing/joost

Browse source 
fix(brian): Take biceps ease into account for armhole depth
This commit is contained in:
Joost De Cock 2024-02-10 17:55:43 +01:00 • committed by GitHub
commit db6fb29e3a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
config/changelog.yaml
View file

@ -26,6 +26,8 @@ Unreleased:
- Calling `Path.join` with a second parameter to indicate that the resulting paths most be closed is now deprecated and will be removed in FreeSewing v4. - Calling `Path.join` with a second parameter to indicate that the resulting paths most be closed is now deprecated and will be removed in FreeSewing v4.
Fixed: Fixed:
brian:
- Take biceps ease into account when calculating armhole depth
carlton: carlton:
- Fixed a stray seam allowance path on the collar - Fixed a stray seam allowance path on the collar
charlie: charlie:

3
designs/brian/src/base.mjs
View file

@ -109,7 +109,8 @@ export const base = {
// The new way uses the waistToArmpit measurement // The new way uses the waistToArmpit measurement
points.cbArmhole = new Point( points.cbArmhole = new Point(
0, 0,
points.cbWaist.y - measurements.waistToArmpit * (1 - options.armholeDepth) points.cbWaist.y -
measurements.waistToArmpit * (1 - options.armholeDepth - options.bicepsEase / 2)
) )
} }