add sinon for better testing

packages/core/package.json

@@ -60,7 +60,10 @@
   },
   "devDependencies": {
     "eslint": "8.34.0",
-    "nyc": "15.1.0"
+    "nyc": "15.1.0",
+    "mocha": "10.0.0",
+    "chai": "4.2.0",
+    "sinon": "^15.0.1"
   },
   "files": [
     "dist/*",

packages/core/src/pattern-draft-queue.mjs

@@ -9,7 +9,7 @@ PatternDraftQueue.prototype.start = function () {
 }
 
 PatternDraftQueue.prototype.addPart = function (partName) {
-  this.queue.push(partName)
+  if (!this.contains(partName)) this.queue.push(partName)
   return this
 }
 
@@ -27,6 +27,10 @@ PatternDraftQueue.prototype.next = function () {
   return next
 }
 
+PatternDraftQueue.prototype.contains = function (partName) {
+  return this.queue.indexOf(partName) !== -1
+}
+
 /**
  * Resolves the draft order based on the configuation
  *

packages/core/src/pattern.mjs

@@ -67,8 +67,11 @@ export function Pattern(designConfig = {}) {
  * It might be useful to not resolve immediately if a number of parts will be added over multiple calls
  * @return {object} this - The Pattern instance
  */
-Pattern.prototype.addPart = function (part, resolveImmediately = false) {
-  if (this.__configResolver.isPartValid(part) && this.designConfig.parts.indexOf(part) === -1) {
+Pattern.prototype.addPart = function (part, resolveImmediately = true) {
+  if (
+    this.__configResolver.isPartValid(part) &&
+    !this.designConfig.parts.find((p) => p.name == part.name)
+  ) {
     this.designConfig.parts.push(part)
     if (resolveImmediately) {
       if (this.__configResolver.addPart(part) && typeof this.draftQueue !== 'undefined')

packages/core/tests/pattern-runtime-parts.test.mjs

@@ -1,5 +1,6 @@
 import chai from 'chai'
 import { Design } from '../src/index.mjs'
+import sinon from 'sinon'
 
 const expect = chai.expect
 
@@ -22,11 +23,6 @@ describe('Pattern', () => {
       draft: ({ part }) => part,
     }
 
-    describe('with runtime: true, resolveImmediately: true', () => {
-      it('adds the part to the current draft cycle')
-      it('does not add the part to subsequent draft cycles')
-    })
-
     describe('with resolveImmediately: true', () => {
       it('Should add the part to parts object', () => {
         const design = new Design({ parts: [part1] })
@@ -152,6 +148,51 @@ describe('Pattern', () => {
         pattern.addPart(part3, true)
         expect(pattern.config.options.opt1).to.equal(opt1)
       })
+
+      describe('during drafting', () => {
+        it('adds the part to the draft queue', () => {
+          const design = new Design({ parts: [part1] })
+          const pattern = new design()
+          pattern.use({
+            name: 'draftTimePartPlugin',
+            hooks: {
+              postPartDraft: (pattern) => {
+                const newPart = {
+                  name: 'newPartTest',
+                  draft: ({ part }) => part,
+                }
+
+                pattern.addPart(newPart)
+              },
+            },
+          })
+
+          pattern.draft()
+          expect(pattern.draftQueue.contains('newPartTest')).to.be.true
+        })
+        it('drafts the part', () => {
+          const design = new Design({ parts: [part1] })
+          const pattern = new design()
+          const part2Draft = ({ part }) => part
+          const draftSpy = sinon.spy(part2Draft)
+          pattern.use({
+            name: 'draftTimePartPlugin',
+            hooks: {
+              postPartDraft: (pattern) => {
+                const newPart = {
+                  name: 'newPartTest',
+                  draft: draftSpy,
+                }
+
+                pattern.addPart(newPart)
+              },
+            },
+          })
+
+          pattern.draft()
+          expect(draftSpy.calledOnce).to.be.true
+        })
+      })
     })
 
     describe('with resolveImmediately: false', () => {