From e5f4fe7824933a7d5a7d60e82792fdbb10d9d233 Mon Sep 17 00:00:00 2001 From: Joost De Cock Date: Thu, 20 Dec 2018 08:30:34 +0100 Subject: [PATCH] bug: Handling scenario when no data is passed to plugin --- packages/plugin-i18n/package.json | 1 + packages/plugin-i18n/src/index.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/packages/plugin-i18n/package.json b/packages/plugin-i18n/package.json index 968aef93d3f..4d111231460 100644 --- a/packages/plugin-i18n/package.json +++ b/packages/plugin-i18n/package.json @@ -33,6 +33,7 @@ "browserbuild": "rollup -c rollup.js --file dist/browser.js --format iife -m true --name freesewing.plugins.i18n", "nodebuild": "rollup -c rollup.js --file dist/index.js --format cjs -m true", "modulebuild": "rollup -c rollup.js --file dist/index.mjs --format es -m true", + "rebuild": "npm run nodebuild && npm run modulebuild", "build": "npm run clean && npm run browserbuild && npm run nodebuild && npm run modulebuild" }, "husky": { diff --git a/packages/plugin-i18n/src/index.js b/packages/plugin-i18n/src/index.js index 857ebd17298..73f6f3bc1b3 100644 --- a/packages/plugin-i18n/src/index.js +++ b/packages/plugin-i18n/src/index.js @@ -10,6 +10,10 @@ export default { } }, insertText: function(locale, text, data) { + if(data === false) { + console.log("No data was passed to the i18n plugin. This plugin won't do much without injecting data into it"); + return text; + } let prefix = data.prefix || ""; if(typeof data.strings[locale][prefix+text] === "undefined") return text; else return data.strings[locale][prefix+text];