VSinerva/freesewing
1
0
Fork 0
Code Activity

fix(albert): Keep straps even when there's no SA

Browse source 
The width of the straps was calculated by multiplying with the `sa`
value.
As a result, when the user asks to draft a pattern without SA, the
straps drop off the pattern.

I've also change the way the width is calculated. It used to be based
on a percentage option that was then multiplied by SA.
While technically that follows the best practice of using percentages,
it won't scale with the model unless you multiply it with a measurement.
This commit is contained in:
Joost De Cock 2020-10-17 15:00:17 +02:00
parent 53a44559ea
commit eebbdd7842
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/albert/config/index.js
View file

@ -34,6 +34,6 @@ export default {
chestDepth: { pct: 22, min: 15, max: 90 },
bibLength: { pct: 75, min: 0, max: 90 },
bibWidth: { pct: 100, min: 50, max: 125 },
strapWidth: { pct: 750, min: 100, max: 1500 }
strapWidth: { pct: 60, min: 20, max: 100 }
}
}

2
packages/albert/src/front.js
View file

@ -26,7 +26,7 @@ export default function (part) {
(1 - options.backOpening)
*/
let apronWidth = measurements.waist * (1 - options.backOpening)
let strapWidth = options.strapWidth * sa
let strapWidth = (measurements.hpsToWaistBack * options.strapWidth) / 8
let hemWidth = 3 * sa
let pocketSize = apronLength / 4

2
packages/albert/src/strap.js
View file

@ -31,9 +31,9 @@ export default function (part) {
measurements.hpsToWaistBack -
measurements.hpsToWaistBack * options.bibLength
let strapWidth = (measurements.hpsToWaistBack * options.strapWidth) / 8
let strapLength =
Math.sqrt(hSpan * hSpan + vSpan * vSpan) + measurements.chest * options.chestDepth
let strapWidth = options.strapWidth * sa
/*
console.log('chestWidth ' + chestWidth)
console.log('backOpening ' + backOpening)