VSinerva/freesewing
1
0
Fork 0
Code Activity

feat(core): Cast distance to number. See #2897

Browse source
This commit is contained in:
Joost De Cock 2022-10-07 21:41:45 +02:00
parent 693243d8e9
commit f759f3986a
3 changed files with 47 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

20
packages/core/src/path.mjs
View file

@ -10,6 +10,7 @@ import {
curveEdge,
round,
__addNonEnumProp,
__asNumber,
} from './utils.mjs'
//////////////////////////////////////////////
@ -540,20 +541,8 @@ Path.prototype.noop = function (id = false) {
* @return {object} this - The Path instance
*/
Path.prototype.offset = function (distance) {
if (typeof distance !== 'number') {
if (typeof distance === 'string') {
this.log.error(
'Called `Path.offset(distance)` but `distance` is not a number. Will attempt to cast to Number'
)
try {
distance = Number(distance)
} catch {
this.log.error(
'Called `Path.offset(distance)` but `distance` is not a number nor can it be cast to one'
)
}
} else this.log.error('Called `Path.offset(distance)` but `distance` is not a number')
}
distance = __asNumber(distance, 'distance', 'Path.offset', this.log)
return __pathOffset(this, distance, this.log)
}
@ -661,8 +650,7 @@ Path.prototype.setText = function (text = '', className = false) {
* @return {Point} point - The point that lies distance along this Path
*/
Path.prototype.shiftAlong = function (distance, stepsPerMm = 10) {
if (typeof distance !== 'number')
this.log.error('Called `Path.shiftAlong(distance)` but `distance` is not a number')
distance = __asNumber(distance, 'distance', 'Path.shiftAlong', this.log)
let len = 0
let current
for (let i in this.ops) {