From f888d0e3cd40bbc942c0fc15916341f2ecefe258 Mon Sep 17 00:00:00 2001 From: Joost De Cock Date: Sun, 3 Jul 2022 13:06:17 +0200 Subject: [PATCH] chore(charlie): Renamed back pocket jet to back pocket welt --- config/changelog.yaml | 2 ++ designs/charlie/config/index.js | 2 +- .../src/{back-pocket-jet.js => back-pocket-welt.js} | 12 ++++++------ designs/charlie/src/index.js | 4 ++-- packages/i18n/src/locales/en/parts.yaml | 1 + 5 files changed, 12 insertions(+), 9 deletions(-) rename designs/charlie/src/{back-pocket-jet.js => back-pocket-welt.js} (83%) diff --git a/config/changelog.yaml b/config/changelog.yaml index ec9c71f210a..e882679bf3d 100644 --- a/config/changelog.yaml +++ b/config/changelog.yaml @@ -1,5 +1,7 @@ Unreleased: Changed: + charlie: + - Renamed back pocket jet to back pocket welt theo: - migrated `waistbandWidth` option from `mm` to snapped `pct` option diff --git a/designs/charlie/config/index.js b/designs/charlie/config/index.js index 3fd9903e31f..66d137eafd1 100644 --- a/designs/charlie/config/index.js +++ b/designs/charlie/config/index.js @@ -71,7 +71,7 @@ export default { frontPocketFacing: 'frontPocket', backPocketFacing: 'backPocket', backPocketInterfacing: 'backPocket', - backPocketJet: 'backPocketFacing', + backPocketWelt: 'backPocketFacing', flyFacing: 'front', flyExtension: 'flyFacing', }, diff --git a/designs/charlie/src/back-pocket-jet.js b/designs/charlie/src/back-pocket-welt.js similarity index 83% rename from designs/charlie/src/back-pocket-jet.js rename to designs/charlie/src/back-pocket-welt.js index c1b5e3b5e12..9cc1c5e21e1 100644 --- a/designs/charlie/src/back-pocket-jet.js +++ b/designs/charlie/src/back-pocket-welt.js @@ -6,13 +6,13 @@ export default (part) => { for (let id in paths) delete paths[id] delete snippets.logo - const jetHeight = points.bottomRight.x / 5 + const weltHeight = points.bottomRight.x / 5 points.bottomLeft = points.curveStartLeft.shift(-90, points.rightNotch.x / 1.75) points.bottomRight = points.bottomLeft.flipX() - points.midLeft = points.bottomLeft.shift(90, jetHeight) - points.midRight = points.bottomRight.shift(90, jetHeight) - points.topLeft = points.bottomLeft.shift(90, jetHeight * 2) - points.topRight = points.bottomRight.shift(90, jetHeight * 2) + points.midLeft = points.bottomLeft.shift(90, weltHeight) + points.midRight = points.bottomRight.shift(90, weltHeight) + points.topLeft = points.bottomLeft.shift(90, weltHeight * 2) + points.topRight = points.bottomRight.shift(90, weltHeight * 2) points.leftNotch = new Point(points.leftNotch.x, points.midRight.y) points.rightNotch = points.leftNotch.flipX() @@ -34,7 +34,7 @@ export default (part) => { macro('title', { at: points.titleAnchor, nr: 4, - title: 'backPocketJet', + title: 'backPocketWelt', scale: 0.5, }) points.grainlineTop = points.topLeft.shiftFractionTowards(points.topRight, 0.15) diff --git a/designs/charlie/src/index.js b/designs/charlie/src/index.js index b1b0eddff2e..e5650336070 100644 --- a/designs/charlie/src/index.js +++ b/designs/charlie/src/index.js @@ -15,7 +15,7 @@ import draftFrontPocketFacing from './front-pocket-facing' import draftBackPocket from './back-pocket' import draftBackPocketFacing from './back-pocket-facing' import draftBackPocketInterfacing from './back-pocket-interfacing' -import draftBackPocketJet from './back-pocket-jet' +import draftBackPocketWelt from './back-pocket-welt' import draftFlyFacing from './fly-facing' import draftFlyExtension from './fly-extension' import draftBeltLoops from './beltloops' @@ -40,7 +40,7 @@ Charlie.prototype.draftFrontPocketFacing = (part) => draftFrontPocketFacing(part Charlie.prototype.draftBackPocket = (part) => draftBackPocket(part) Charlie.prototype.draftBackPocketFacing = (part) => draftBackPocketFacing(part) Charlie.prototype.draftBackPocketInterfacing = (part) => draftBackPocketInterfacing(part) -Charlie.prototype.draftBackPocketJet = (part) => draftBackPocketJet(part) +Charlie.prototype.draftBackPocketWelt = (part) => draftBackPocketWelt(part) Charlie.prototype.draftFlyFacing = (part) => draftFlyFacing(part) Charlie.prototype.draftFlyExtension = (part) => draftFlyExtension(part) Charlie.prototype.draftBeltLoops = (part) => draftBeltLoops(part) diff --git a/packages/i18n/src/locales/en/parts.yaml b/packages/i18n/src/locales/en/parts.yaml index cae47214e0d..fbe657504ab 100644 --- a/packages/i18n/src/locales/en/parts.yaml +++ b/packages/i18n/src/locales/en/parts.yaml @@ -1,5 +1,6 @@ back: Back backBase: Back base +backPocketWelt: Back pocket welt base: Base bentBack: Bent back bentBase: Bent base