VSinerva/freesewing
1
0
Fork 0
Code Activity

feat(core): Added Path.clean() method. Closes #3038 and #3056

Browse source 
This is a fix for bug #3038 which was investigated by @BenJamesBen
who also proposed a fix in PR #3056

However, after discussing the matter, we agreed it would be better
to have a generic method in core to guard against the issue of
spurious drawing operations.

This commit adds the `Path.clean()` method that does exactly that,
as well as its documentation.
This commit is contained in:
joostdecock 2022-12-03 17:25:19 +01:00
parent d9862326b2
commit fab1e2f877
2 changed files with 90 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
packages/core/src/path.mjs
View file

@ -166,6 +166,34 @@ Path.prototype.bbox = function () {
return __bbbbox(bbs)
}
/**
* Returns this after cleaning out in-place path operations
*
* Cleaned means that any in-place ops will be removed
* An in-place op is when a drawing operation doesn't draw anything
* like a line from the point to the same point
*
* @return {Path} this - This, but cleaned
*/
Path.prototype.clean = function () {
const ops = []
for (const i in this.ops) {
const op = this.ops[i]
if (['move', 'close', 'noop'].includes(op.type)) ops.push(op)
else if (op.type === 'line') {
if (!op.to.sitsRoughlyOn(cur)) ops.push(op)
} else if (op.type === 'curve') {
if (!(op.cp1.sitsRoughlyOn(cur) && op.cp2.sitsRoughlyOn(cur) && op.to.sitsRoughlyOn(cur)))
ops.push(ops)
}
const cur = op?.to
}
if (ops.length < this.ops.length) this.ops = ops
return this
}
/**
* Returns a deep copy of this path
*
@ -1117,6 +1145,7 @@ function __asPath(bezier, log = false) {
new Point(bezier.points[2].x, bezier.points[2].y),
new Point(bezier.points[3].x, bezier.points[3].y)
)
.clean()
}
/**