1
0
Fork 0
Commit graph

19 commits

Author SHA1 Message Date
joostdecock
a30b08371c feat(core): Added Path.combine and related changes, closes #5976
The discussion in #5976 is whether `Path.join()` should use a line
segment to close any gaps in the path caused by move operations, or by
differences in the end and start points of paths being joined.

The answer is yes, that is the intended behaviour, but people who read
_join_ might expect differently.

So I have made a few changes to clarify this:

- The new `Path.combine()` method combines multiple path instances into
  a single instance without making any changes to the drawing operations
- Since `Path.combine()` is variadic, I have also updated `Path.join()`
  to be variadic too, since that is more consistent.
- The old way of calling `Path.join(path, bool)` is deprecated and will
  log a warning. Calling `Path.join()` this way will be removed in v4.
- Related to this change is how `Path.length()` should behave when there
  are gaps in the path. Currently, it skips those. So I've added a
  parameter that when set to `true` will include them.
- Added documentation for `Path.combine()`
- Updated documentation for `Path.join()`
- Updated documentation for `Path.length()`
2024-02-10 15:40:41 +01:00
joostdecock
26e282f5b7 fix: Fix tests after major chai upgrade
Note that the tests for Lumina are failing, but that's not related to
the chai upgrade, rather it seems these tests fail because of issues in
the design that we'll tackle later (it's a brand new design yet to be
released).
2024-02-04 12:14:42 +01:00
Benjamin Fan
5828e53937 fix(core): Remove Svg.body property 2024-01-24 20:18:03 -08:00
joostdecock
5c00551bca chore(core): log.warning is now log.warn 2023-09-05 12:00:05 +02:00
Enoch Riese
8fea9a4beb refactor (core) move draft handling into its own class 2023-04-18 17:12:55 -04:00
Enoch Riese
9e8db66c94 refactor (core) move packing and rendering to its own class 2023-04-18 17:12:55 -04:00
Enoch Riese
e3acb96ee2 lint fix 2023-01-07 15:42:54 -06:00
Enoch Riese
f060abbee0 add test 2023-01-07 15:37:43 -06:00
Enoch Riese
4f42f4038c test the security fix 2022-12-08 20:06:22 -06:00
Enoch Riese
59bf4ffb51 test uncovered lines 2022-12-04 16:59:34 -06:00
Joost De Cock
322100f54c chore: Extended prettier for config files + run 2022-10-13 16:19:36 +02:00
Joost De Cock
22680fbddc chore(core): Change init to be private (__init) 2022-09-20 15:24:10 +02:00
Joost De Cock
d5eb2946d3 chore(core): More unit tests 2022-09-19 18:04:47 +02:00
Joost De Cock
200cebf582 chore(core): Refactor v3 code 2022-09-18 15:11:10 +02:00
Joost De Cock
a416b8b860 chore: More linting 2022-09-15 13:49:55 +02:00
Joost De Cock
56427cc4bd chore(core): Linter fixes 2022-09-15 06:34:05 +02:00
Joost De Cock
ef5e792d6b chore: Linter fixes 2022-09-14 15:02:39 +02:00
joostdecock
48b366c57e fix(core): Issue with hiding dependencies 2022-09-11 18:00:41 +02:00
joostdecock
b7071bb487 wip(core): Unit tests 2022-09-10 18:45:57 +02:00
Renamed from packages/core/tests/pattern-draft.mjs (Browse further)