This PR changes how the Wahid pattern is generated to improve widths at the waist and hips. It does so by using the actual waist and hips measurements to generate the waist and hips points, as opposed to the old method which used the chest circumference as the base to approximate the waist and hips points. The new method results in a pattern where the chest/waist/hips widths of the garment are exactly the values of chest/waist/hips measurements plus ease.
The changes are controlled by a new Legacy Waist and Hips option. The option is disabled by default, but when it is enabled the Wahid pattern is generated the old way. So, users will be able to generate the same Wahid patterns as before, if desired.
The PR also contains a fix for the front pocket angle.
The waist and hips changes were tested by someone who reported that it fixed their sway back issue:
1367899207
discord://discord.com/channels/698854858052075530/757631205804998759/1367899207553388556
Fixes#302Fixes#328
Co-authored-by: Benjamin Fan <ben-git@swinglonga.com>
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/352
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Benjamin Fan <benjamesben@noreply.codeberg.org>
Co-committed-by: Benjamin Fan <benjamesben@noreply.codeberg.org>
sidebar_class_name: 'tw:hidden' doesn't seem to work when the page is an index.mdx inside some folder. Make it a top-level document instead
Fixes#275
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/295
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Also by default view imperial measurement sets as imperial and metric ones as metric (this is questionable, and should probably be discussed, alternatively we could default displayAsMetric to the account setting?)
Fixes#230
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/247
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Various fixes for the measurement view and editor:
- Translate measurements in the measurement set view and align the measurements table properly
- Display a question mark next to the measurements that links to the corresponding docs page
This fixes a part of #226
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/233
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
The link to the video in the simon sew-along is broken. Remove the sew along from the Simon shirt sewing instructions.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/214
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Josh Munic <jpmunic@gmail.com>
Co-committed-by: Josh Munic <jpmunic@gmail.com>
Closes#105Closes#76Closes#148
This is a major clean up and overhaul of Bee's code.
Changes
- Reinstating the ability to toggle the colours of neck and band tie independently
- Reinstating the ability to toggle pointed edge of neck and band tie independently
- Simplify snap options
- Simplfication of the code
- Simplify Cutting Instructions
- Cutlist re-work
- Hidden tie flag message also now appears when !options.ties
- Neck tie is no longer hidden when options.pointedNeckTieEnds == true
- Band tie is no longer hidden when options.crossBackTies == true
- Band tie is no longer hidden when options.pointedBandTieEnds == true && !options.crossBackTies
- options.reversible now acts as an override for options.duoNeckTieColours & options.duoBandTieColours
- options.reversible markdown updated to reflect this
- Updated neckTieLength when crossBackTies == true this was an error from the original code.
- Designer note links updated for new options.
- i18n en.json file updated to reflect change in options
Fixes
- Neck ties no longer cut on fold (This was an error from when originally coded)
- Band tie locks in duo colours when options.crossBackTies == true (this is why there were incorrect notch placements)
- options.bandLength move to neck.mjs
- Locking Bella options that were added post Bee.
Additions
- options.duoNeckTieColours
- options.duoBandTieColours
- options.pointedNeckTieEnds
- options.pointedBandTieEnds
- New option markdown
- Added snap info to neckTieWidth & bandTieWidth markdown
Removed
- options.duoTieColors
- options.pointedTieEnds
- removed option markdown
- Hidden tie flag message has had expand flags removed
Things to Note
- The cut list is not using the mirrored preset to hopefully lessen confusion.
Moving forward, as the original coder of this design, in an effort to maintain the design as intended by the original designer in the future, it would streamline the process and be helpful if any requests for maintenance were sent directly to me.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/200
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Co-committed-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Refer to the CHANGELOG for all info.
---------
Co-authored-by: Wouter van Wageningen <wouter.vdub@yahoo.com>
Co-authored-by: Josh Munic <jpmunic@gmail.com>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
