1
0
Fork 0
Commit graph

18 commits

Author SHA1 Message Date
joostdecock
01e2d4e41a Merge branch 'develop' into joost 2023-06-12 18:22:14 +02:00
joostdecock
c5753abdc0 feat(core): Allow toAbs for non-snapped values too 2023-06-11 18:04:49 +02:00
joostdecock
631ea8a50d feat(core): New mergeOptions method and passing mergedOtions to toAbs
When using toAbs for all but the most trivial cases, one needs access to
the options. Unlike measurements which are always there, options aren't
always set since they are only set when they differ from the default.

This would shift a lot of responsibility on the pattern designer who
would have to check whether an option is set, and if it's not use the
default which in turn depends on what type of an option it is (and it's
pct for example you have to remember to divide it by 100 and so on).

This feels footgun-y so instead I've added a `mergeOptions` method that
merges the options passed by the user with the defaults from the pattern
config so that you have a simple object with all option values.

This should get passed to `toAbs()` as the 3rd parameter.
2023-06-11 14:16:07 +02:00
joostdecock
c1fdf83088 feat(core): Consistent debug output style 2023-06-11 09:41:32 +02:00
joostdecock
46f547eb14 feat(core): Log message formatting improvements 2023-06-11 09:36:16 +02:00
joostdecock
a2800dddda feat(core): Added Pattern.getLogs() and updated Pattern.getRenderProps()
The data returned by `Pattern.getRenderProps()` was not serializable as
we were returning `this` all over the place, thereby including marcors,
log methods, cyclic object references, and so on.

This commit changes that by implementing a `.asRenderProp()` method on
all of the various objects (stack, part, path, point, snippet,
attributes, svg) and only including data that can be serialized.

In addition, we no longer include the logs in the renderProps because
they are not related to rendering the pattern.
Instead, the new method `Pattern.getLogs()` gives you the logs.
2023-06-01 16:45:13 +02:00
Enoch Riese
cc143153b2 fix (core) resolve after depenndencies before from dependencies 2023-05-22 16:16:05 -05:00
Enoch Riese
282696f1cd fixes #3957 re-use existing part for out-of-cycle draft 2023-05-02 12:25:04 -05:00
Enoch Riese
da76f23274 add back in accidentally deleted method 2023-04-20 10:07:43 -04:00
Enoch Riese
5abd8e166b chore (core) document new classes [vercel skip] 2023-04-19 12:40:48 -04:00
Enoch Riese
c6d4fc3aea fix (core) fix rounding in count sampling. add tests 2023-04-19 11:30:32 -04:00
Enoch Riese
8ccab0df21 chore (core) cleanup 2023-04-18 18:47:49 -04:00
Enoch Riese
13ec5e43e5 refactor (core) reorganize method groupings in Pattern 2023-04-18 17:12:55 -04:00
Enoch Riese
8fea9a4beb refactor (core) move draft handling into its own class 2023-04-18 17:12:55 -04:00
Enoch Riese
9e8db66c94 refactor (core) move packing and rendering to its own class 2023-04-18 17:12:55 -04:00
Enoch Riese
c5baaab234 refactor (core) move plugin and hook handling to its own class 2023-04-18 17:12:55 -04:00
Enoch Riese
e59341effa refactor (core) separate sampling into its own handler 2023-04-18 17:12:55 -04:00
Enoch Riese
3c54e94c43 chore (core) move pattern related classes to their own folder 2023-04-18 17:12:55 -04:00