1
0
Fork 0
Commit graph

1390 commits

Author SHA1 Message Date
Benjamin Fan
daa65969ac fix(designs): Typo fixes in json files 2024-02-21 13:59:39 -08:00
Joost De Cock
2fab64c29e
Merge pull request #6089 from BenJamesBen/brian-grainline-warning
fix(brian): Eliminate warning message
2024-02-18 15:50:48 +01:00
Joost De Cock
9685e498e2
Merge pull request #6088 from BenJamesBen/hugo-waistband-grainline
fix(hugo): Correct waistband grainline direction
2024-02-18 15:50:10 +01:00
Benjamin Fan
84eb035a84 fix(brian): Remove unused shorthand 2024-02-17 19:56:55 -08:00
Benjamin Fan
b400e086ab fix(brian): Remove superfluous code from sleevecap 2024-02-17 19:22:37 -08:00
Benjamin Fan
aab14ba1ea fix(hugo): Add grainline info to expand flag details 2024-02-17 18:51:51 -08:00
Benjamin Fan
8cd4a1aaa6 fix(hugo): Correct waistband grainline direction 2024-02-17 18:51:20 -08:00
Benjamin Fan
9a4fe14892 chore(onyx, shelly, tamiko): Load bustPlugin unconditionally 2024-02-17 08:11:55 -08:00
joostdecock
786a5d06cb chore(brian): Always load plugin-bust
The plugin changed how it handles conditionality, so we are always
loading it.
2024-02-17 16:06:32 +01:00
Benjamin Fan
8ecb17d9c1 fix(hugo): Add missing dimension id attributes 2024-02-13 14:54:36 -08:00
dependabot[bot]
e55f384618
Bump chai from 5.0.3 to 5.1.0
Bumps [chai](https://github.com/chaijs/chai) from 5.0.3 to 5.1.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-13 04:23:41 +00:00
Joost De Cock
0a224d42f6
Merge pull request #6020 from BenJamesBen/tristan-peplum-typo
fix(tristan): Typo in flag message
2024-02-12 17:43:45 +01:00
dependabot[bot]
5cf54d8393
Bump mocha from 10.2.0 to 10.3.0
Bumps [mocha](https://github.com/mochajs/mocha) from 10.2.0 to 10.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v10.2.0...v10.3.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 08:41:43 +00:00
joostdecock
59adf43911 chore: Set engines in package.json 2024-02-11 17:31:52 +01:00
joostdecock
38bb3bc6f0 release: v3.2.0
- Added:
  - core:
    - Added the `Path.combine()` method
    - The `Path.join()` method is now variadic
    - The `Path.length()` now takes an parameter to include move operations in the length calculation
  - lumina:
    - Initial release
  - lumira:
    - Initial release
  - plugin-annotations:
    - The `title` macro now takes a `notes` and `classes.notes` as its config, allowing you to add notes
    - The `classes.cutlist` config is removed from the title plugin, cutlist info is now included as notes
  - plugin-i18n:
    - This plugin now supports translation of nested arrays of strings, giving you more flexibility to concatenate translated parts of strings
  - react-components:
    - This Pattern component now supports translation of nested arrays of strings, giving you more flexibility to concatenate translated parts of strings
  - sandy:
    - Added a new *panels* option
  - tristan:
    - Inital release
- Deprecated:
  - core:
    - Calling `Path.join` with a second parameter to indicate that the resulting paths most be closed is now deprecated and will be removed in FreeSewing v4.
- Fixed:
  - brian:
    - Take biceps ease into account when calculating armhole depth
  - carlton:
    - Fixed a stray seam allowance path on the collar
  - charlie:
    - The back pocket welt (4) and front pocket facing (8) incorrectly indicated to cut 2 instead of 4 in the cutlist. Fixes #5791
  - hugo:
    - Fix issue that crashed the design when complete is off. Fixes #6006
    - Base pocket opening on pocket height, rather than width of the garment. Fixes #6004
- Removed:
  - plugin-annotations:
    - The `classes.cutlist` config is removed from the title plugin, cutlist info is now included as notes

Shout-out to @woutervdub and @benjamesben for their many contributotions
to this v3.2 release 🙏
2024-02-11 13:43:07 +01:00
joostdecock
617fb6fa17 chore: Preparing 3.2 release 2024-02-11 13:30:18 +01:00
Joost De Cock
f43f7b5561
Merge pull request #6010 from freesewing/joost
fix(huge): Base pocket opening on pocket height. Fixes #6004
2024-02-11 12:56:13 +01:00
joostdecock
a520b08b5d fix(huge): Base pocket opening on pocket height. Fixes #6004 2024-02-11 12:51:16 +01:00
Joost De Cock
4429976218
Merge pull request #6009 from freesewing/joost
fix(hugo): Incorrect complete check. Closes #6006
2024-02-11 11:47:25 +01:00
joostdecock
b01a650a5f fix(hugo): Incorrect complete check. Closes #6006 2024-02-11 11:44:36 +01:00
Natalia Sayang
08c35b57bd Updating name from "Tristan" to "Tristan top" on designs page 2024-02-11 02:52:51 +00:00
joostdecock
91c5edb1aa fix(brian): Take biceps ease into account for armhole depth
Originally, #5999 was filed to report issues with the sleeve on Jaeger
not responding to biceps ease as expected. Increasing the biceps ease
would actually make the sleeve more narrow.

Turns out, this is a side-effect of the way the armhole depth is
calculated in v3. We used to take the biceps measurement (and ease) for
that, but now we rely on the waist to armpit measurements.

In brain, we used this new measurements along with the
armholeDepthFactor option to locate the bottom of the armhole.
This means that when we change the biceps ease, nothing will change in
the briam armhole, which means the total sleevecap length target remains
unchanges.
However, in Jaeger, increased biceps ease causes a taller sleevecap, and
since the total target sleevecap length (inherited from Brian) remains
unchanged, the pattern accomodates by making the sleeve more narrow so
that the taller sleevecap has the same sleevecap length. This is what
results in the counterintuitive behavior where increasing the biceps
ease makes the sleevecap more narrow.

This resolves that by taking the biceps ease into account when
calculating the bottom of the armhole in Brian. As a result, changing
the biceps ease will impact the armhole on Brian, which will in turn
influence the target sleevecap length that Bent drafts a 2-part sleeve
for, and now things work as aspected.

Given that Brian is such a foundational block, making changes to it is a
high-stakes game, but I feel this is a bug, so we need to fix it.

Fixes #5999
2024-02-10 17:38:57 +01:00
Joost De Cock
323d8d5bd7
Merge pull request #5916 from BenJamesBen/jaeger-3820
fix(jaeger): Fix undercollar to correct shape
2024-02-10 14:02:20 +01:00
Joost De Cock
2bfcb577ab
Merge pull request #5859 from BenJamesBen/sandy-outer-dimensions
fix(sandy): Correct vertical dimensions, and add horizontal dimensions
2024-02-10 14:01:36 +01:00
dependabot[bot]
64959fc0ab
build(deps-dev): bump mocha from 10.2.0 to 10.3.0
Bumps [mocha](https://github.com/mochajs/mocha) from 10.2.0 to 10.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v10.2.0...v10.3.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-09 04:57:52 +00:00
48975aa8a9 Remove unused trailing parameter 2024-02-07 16:27:12 +02:00
1b402ef9f9 Fix conditional menu definitions for test view 2024-02-07 15:36:31 +02:00
Benjamin Fan
f954c9603d fix(jaeger): Remove unused options from shorthand 2024-02-06 10:47:39 -08:00
Benjamin Fan
d8451a10e6 fix(jaeger): Correct seam allowance to include only side edges 2024-02-06 10:47:38 -08:00
Benjamin Fan
c0269ff624 fix(jaeger): Revert under-collar-and-stand terminology back to undercollar 2024-02-06 10:47:32 -08:00
Benjamin Fan
85a4dffef5 fix(jaeger): Change dimensions to full part size 2024-02-06 10:47:32 -08:00
Benjamin Fan
71edba47e3 fix(jaeger): Correct undercollar to be 1 piece 2024-02-06 10:47:28 -08:00
Benjamin Fan
485aabe863 fix(jaeger): Change undercollar to under-collar-and-stand 2024-02-06 10:47:24 -08:00
Benjamin Fan
c155b39ee1 fix(sandy): Correct vertical dimensions, and add horizontal dimensions 2024-02-05 18:07:07 -08:00
woutervdub
fd8dc3e4b4 Resolves #5956 2024-02-04 19:19:33 +00:00
Benjamin Fan
1b6932cab7 fix(tristan): Typo in flag message 2024-02-04 05:46:12 -08:00
joostdecock
703f8fd6e1 chore: Updated dependencies 2024-02-04 11:54:17 +01:00
joostdecock
f2353ba177 chore: Updated changelog with tristan release 2024-02-04 10:54:27 +01:00
joostdecock
add96a0ee2 chore: Updated README templates 2024-02-04 10:52:16 +01:00
joostdecock
038d0f3903 Merge branch 'develop' into joost 2024-02-04 10:17:39 +01:00
Joost De Cock
6afc699fc3
Merge pull request #5802 from woutervdub/lumina
Lumina
2024-02-04 10:12:42 +01:00
Joost De Cock
aac82a06d4
Merge pull request #5849 from freesewing/tristan
Add `tristan` to FreeSewing
2024-02-04 10:08:18 +01:00
Joost De Cock
37252bdd55
Merge pull request #5861 from pvidas/sandy-panels-option
Add panels option to Sandy
2024-02-03 17:17:43 +01:00
Joost De Cock
337c2c39ac
Merge pull request #5905 from freesewing/dependabot/npm_and_yarn/chai-5.0.3
build(deps-dev): bump chai from 4.3.10 to 5.0.3
2024-02-03 17:10:45 +01:00
Joost De Cock
80bc843189
Merge pull request #5912 from BenJamesBen/hugo-3341
fix(hugo): Add neck binding part
2024-02-03 17:06:08 +01:00
Joost De Cock
53e3c967d9
Merge pull request #5917 from BenJamesBen/carlton-collar-sa
fix(carlton) Fix stray seam allowance path
2024-02-03 16:53:56 +01:00
dependabot[bot]
57b64af805
build(deps-dev): bump chai from 4.3.10 to 5.0.3
Bumps [chai](https://github.com/chaijs/chai) from 4.3.10 to 5.0.3.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](https://github.com/chaijs/chai/compare/v4.3.10...v5.0.3)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-30 18:15:52 +00:00
Benjamin Fan
2c5260a3bf fix(brian): Fix i18n json structure 2024-01-29 21:30:20 -08:00
Benjamin Fan
0b6bb28dc8 fix(brian): Flag.warn if shoulder width too large 2024-01-28 17:25:06 -08:00
Benjamin Fan
92c856209b fix(carlton) Fix stray seam allowance path 2024-01-28 16:25:17 -08:00