Fixes#54
Also adds the fabric class to lumina parts for proper line width and rainbow coloring.
The last commit is probably not right. It works, but I'm not sure if these are the right functions to change.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/261
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Running `updateHandler(part, undefined)` will set the setting to null instead of removing/resetting it, which causes problems.
Fixes#239
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/259
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
- Give up early if the curve is empty (or otherwise malformed, i.e. if it contains NaN points), instead of iterating endlessly
- Limit the iterations to 20 as the comment says
- Don't go above 1 for the t values
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/257
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
This fixes some react wiring in the inspect view.
The drillProps argument contains the info function which displays the popup. Also `strings` should be passed for translation, instead of the t function.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/256
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Also by default view imperial measurement sets as imperial and metric ones as metric (this is questionable, and should probably be discussed, alternatively we could default displayAsMetric to the account setting?)
Fixes#230
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/247
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
This plug-in helps with creating seam allowance and hem paths.
Rebased v4 version for #99, see the linked issue for screenshots/details.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/236
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Various fixes for the measurement view and editor:
- Translate measurements in the measurement set view and align the measurements table properly
- Display a question mark next to the measurements that links to the corresponding docs page
This fixes a part of #226
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/233
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Fixes#229
unsure if expand is intended to be enabled or disabled by default, I opted for saving paper by default, but this can be easily changed.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/234
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
This ensures that we catch crashes that only occur with certain options set and/or only with sa and/or complete enabled.
Closes#189Closes#85
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/225
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/221
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Fix the export functionality in the pattern editor:
* Fix the export button in the header bar
* Fix the copy to clipboard buttons displaying no text and having a weird styling.
Before:
After:
Fixes#215
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/218
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
The link to the video in the simon sew-along is broken. Remove the sew along from the Simon shirt sewing instructions.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/214
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Josh Munic <jpmunic@gmail.com>
Co-committed-by: Josh Munic <jpmunic@gmail.com>
If drafting a part fails, the logs store contains an array [message, stacktrace] instead of a simple string. Handle this in the LogView.
Also display an error message in the DraftView when there were errors during drafting.
after clicking the button:
(could also display the stack traces, but they're quite unhelpful and you can find them in the browser console anyway, the code for that is commented out)
Closes#163
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/205
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
Closes#140
The shared path causes the logo to be offset differently so to fix this making a slight tweak to the translate.
Before
After
Designs after Oct 2023 will have used the incorrect one so may need tweaking down the line.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/202
Co-authored-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Co-committed-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Closes#105Closes#76Closes#148
This is a major clean up and overhaul of Bee's code.
Changes
- Reinstating the ability to toggle the colours of neck and band tie independently
- Reinstating the ability to toggle pointed edge of neck and band tie independently
- Simplify snap options
- Simplfication of the code
- Simplify Cutting Instructions
- Cutlist re-work
- Hidden tie flag message also now appears when !options.ties
- Neck tie is no longer hidden when options.pointedNeckTieEnds == true
- Band tie is no longer hidden when options.crossBackTies == true
- Band tie is no longer hidden when options.pointedBandTieEnds == true && !options.crossBackTies
- options.reversible now acts as an override for options.duoNeckTieColours & options.duoBandTieColours
- options.reversible markdown updated to reflect this
- Updated neckTieLength when crossBackTies == true this was an error from the original code.
- Designer note links updated for new options.
- i18n en.json file updated to reflect change in options
Fixes
- Neck ties no longer cut on fold (This was an error from when originally coded)
- Band tie locks in duo colours when options.crossBackTies == true (this is why there were incorrect notch placements)
- options.bandLength move to neck.mjs
- Locking Bella options that were added post Bee.
Additions
- options.duoNeckTieColours
- options.duoBandTieColours
- options.pointedNeckTieEnds
- options.pointedBandTieEnds
- New option markdown
- Added snap info to neckTieWidth & bandTieWidth markdown
Removed
- options.duoTieColors
- options.pointedTieEnds
- removed option markdown
- Hidden tie flag message has had expand flags removed
Things to Note
- The cut list is not using the mirrored preset to hopefully lessen confusion.
Moving forward, as the original coder of this design, in an effort to maintain the design as intended by the original designer in the future, it would streamline the process and be helpful if any requests for maintenance were sent directly to me.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/200
Reviewed-by: Joost De Cock <joostdecock@noreply.codeberg.org>
Co-authored-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Co-committed-by: bobgeorgethe3rd <bobgeorgethe3rd@googlemail.com>
Fixes#197
Not tested in detail since that needs an account without measurement sets, which I don't have.
Reviewed-on: https://codeberg.org/freesewing/freesewing/pulls/201
Co-authored-by: Jonathan Haas <haasjona@gmail.com>
Co-committed-by: Jonathan Haas <haasjona@gmail.com>
