joostdecock
43c069719c
Revert "feat(shared): Add name to curated sets"
...
This reverts commit 5dc84c0eb8
2024-02-17 16:50:47 +01:00
joostdecock
147433e168
Revert "fix(shared): Add key prop to iterator"
...
This reverts commit 9cdf064b46
2024-02-17 16:50:22 +01:00
joostdecock
9cdf064b46
fix(shared): Add key prop to iterator
2024-02-17 16:48:18 +01:00
joostdecock
5dc84c0eb8
feat(shared): Add name to curated sets
...
This replaces #6077 and closes #5898 but does so with proper CSS.
2024-02-17 16:44:46 +01:00
Joost De Cock
c20ed9743d
Merge pull request #6076 from BenJamesBen/include-setname-in-titles-and-pdf
...
fix(shared, plugins): Provide measurement set name to patterns
2024-02-17 16:31:33 +01:00
Joost De Cock
b7d19fd988
Merge pull request #6075 from BenJamesBen/optional-measurements-missing
...
fix(shared): Add optional measurements to pattern Edit Measurements by Hand
2024-02-17 16:28:19 +01:00
joostdecock
c3ea6bc5c2
chore(plugin-bust): Removed unused variable
2024-02-17 16:24:39 +01:00
joostdecock
3b7615f03a
feat(markdown): Added notes to lifecycle hooks docs
2024-02-17 16:14:14 +01:00
joostdecock
786a5d06cb
chore(brian): Always load plugin-bust
...
The plugin changed how it handles conditionality, so we are always
loading it.
2024-02-17 16:06:32 +01:00
joostdecock
4264c81070
feat[plugin-bust]: Move conditionality to preSetDraft lifecycle hook
...
This plugin is used to draft designs for high bust rather than full
chest circumference. To facilitate that, we provide(d) a named export
called `withCondition` that checks whether the plugin is wanted, and if
so loads it.
Problem with that is that the conditional loading of a plugin applied
to the entire pattern. And since we support drafting patterns for
multiple sets (and use this to sample) this means that all of these sets
would either get the plugin effect or not, based on the first set.
So, to fix that, we have changed the lifecycle hook used by this plugin
to `preSetDraft` (from `preDraft`) and changed the `withCondition`
method to always return true.
This means that the plugin will always be loaded, and we have moved the
check that used to be in `withCondition` to the lifecycle hook.
In other words, this plugin will now always be loaded and will check for
each set whether it needs to do something.
This allows the conditionality to apply to each set in the pattern,
rather than to the entire pattern.
Note that conditionally loading plugins pattern-wide is still a valid
use-case. It just so happens that for this plugin, it was the wrong
approach.
2024-02-17 15:57:40 +01:00
Natalia Sayang
ca6b343919
Adds Charlie, Cornelius, and Florent line drawings
2024-02-17 03:38:05 +00:00
Benjamin Fan
b9f9226587
fix(shared): Remove unused variable
2024-02-16 18:09:29 -08:00
Joost De Cock
cf29b18dde
Update source file en.md
...
skip-build
2024-02-16 21:32:26 +01:00
Joost De Cock
4ae5598a5a
Update source file en.md
...
skip-build
2024-02-16 21:32:26 +01:00
Joost De Cock
f480882a0a
Update source file en.md
...
skip-build
2024-02-16 21:32:25 +01:00
Joost De Cock
5420bcba4e
Update source file en.md
...
skip-build
2024-02-16 21:32:25 +01:00
Joost De Cock
5690d78761
Update source file en.md
...
skip-build
2024-02-16 21:32:24 +01:00
Joost De Cock
fe21fd50ba
Update source file en.md
...
skip-build
2024-02-16 21:32:23 +01:00
Joost De Cock
37b77ccb44
Update source file en.md
...
skip-build
2024-02-16 21:32:23 +01:00
Joost De Cock
17a4cbf00b
New translations en.yaml (Ukrainian)
...
skip-build
2024-02-16 21:11:34 +01:00
Joost De Cock
d42f9961e0
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:15 +01:00
Joost De Cock
92a438e636
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:14 +01:00
Joost De Cock
bdcae197d6
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:12 +01:00
Joost De Cock
7af439b97d
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:11 +01:00
Joost De Cock
d674e58ab5
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:10 +01:00
Joost De Cock
5b7331276b
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:09 +01:00
Joost De Cock
2d08c02240
New translations en.md (Ukrainian)
...
skip-build
2024-02-16 21:01:07 +01:00
Joost De Cock
1a44f4a261
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:51 +01:00
Joost De Cock
a3feb5bb41
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:50 +01:00
Joost De Cock
bff52e90f4
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:35 +01:00
Joost De Cock
942bf3a4ae
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:34 +01:00
Joost De Cock
55d075cd04
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:32 +01:00
Joost De Cock
50ae3c9351
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:31 +01:00
Joost De Cock
bc6dcb1764
New translations en.md (Dutch)
...
skip-build
2024-02-16 20:38:30 +01:00
Joost De Cock
7df835441b
New translations en.yaml (German)
...
skip-build
2024-02-16 20:26:29 +01:00
Joost De Cock
beb87d646e
New translations en.md (German)
...
skip-build
2024-02-16 20:16:09 +01:00
Joost De Cock
e2bd88131b
New translations en.md (German)
...
skip-build
2024-02-16 20:16:08 +01:00
Joost De Cock
88912c0fcd
New translations en.md (German)
...
skip-build
2024-02-16 20:16:07 +01:00
Joost De Cock
5a808c94ce
New translations en.md (German)
...
skip-build
2024-02-16 20:16:06 +01:00
Joost De Cock
9730947d80
New translations en.md (German)
...
skip-build
2024-02-16 20:16:04 +01:00
Joost De Cock
3513c22228
New translations en.md (German)
...
skip-build
2024-02-16 20:16:04 +01:00
Joost De Cock
453e9298fe
New translations en.md (German)
...
skip-build
2024-02-16 20:16:02 +01:00
Benjamin Fan
0d4eef107d
fix(shared): Add optional measurements to pattern Edit Measurements by Hand
2024-02-16 11:10:32 -08:00
Joost De Cock
fc393cf919
New translations en.yaml (Spanish)
...
skip-build
2024-02-16 20:03:59 +01:00
Joost De Cock
0f367133c9
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:35 +01:00
Joost De Cock
f50322cf02
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:34 +01:00
Joost De Cock
561e03ae63
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:33 +01:00
Joost De Cock
8065c451ff
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:32 +01:00
Joost De Cock
903bf9383e
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:30 +01:00
Joost De Cock
d57c2161c4
New translations en.md (Spanish)
...
skip-build
2024-02-16 19:53:29 +01:00
