Joost De Cock
5a3e23ddd2
Merge branch 'joost/customlayout' into develop
2022-03-16 18:33:31 +01:00
Joost De Cock
acb068086c
Merge pull request #2002 from freesewing/dependabot/npm_and_yarn/mongoose-6.2.6
...
Bump mongoose from 6.2.4 to 6.2.6
2022-03-16 06:51:22 +01:00
dependabot[bot]
918b86dcae
Bump mongoose from 6.2.4 to 6.2.6
...
Bumps [mongoose](https://github.com/Automattic/mongoose ) from 6.2.4 to 6.2.6.
- [Release notes](https://github.com/Automattic/mongoose/releases )
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Automattic/mongoose/compare/6.2.4...6.2.6 )
---
updated-dependencies:
- dependency-name: mongoose
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-16 04:36:21 +00:00
Joost De Cock
de864d5655
chore: Updated contributor call date
2022-03-15 18:17:24 +01:00
Nick Dower
0d044757f1
Merge pull request #1999 from freesewing/dependabot/npm_and_yarn/sharp-0.30.3
...
Bump sharp from 0.30.2 to 0.30.3
2022-03-15 09:58:23 +01:00
Nick Dower
35ade7c9dc
Merge pull request #2000 from freesewing/dependabot/npm_and_yarn/netlify-cli-9.13.1
...
Bump netlify-cli from 9.13.0 to 9.13.1
2022-03-15 09:58:13 +01:00
Nick Dower
d7555386e1
Merge pull request #2001 from freesewing/dependabot/npm_and_yarn/types/react-17.0.40
...
Bump @types/react from 17.0.39 to 17.0.40
2022-03-15 09:58:03 +01:00
dependabot[bot]
fcc9ad3768
Bump @types/react from 17.0.39 to 17.0.40
...
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react ) from 17.0.39 to 17.0.40.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react )
---
updated-dependencies:
- dependency-name: "@types/react"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-15 04:43:20 +00:00
dependabot[bot]
8bfae3aa04
Bump netlify-cli from 9.13.0 to 9.13.1
...
Bumps [netlify-cli](https://github.com/netlify/cli ) from 9.13.0 to 9.13.1.
- [Release notes](https://github.com/netlify/cli/releases )
- [Changelog](https://github.com/netlify/cli/blob/main/CHANGELOG.md )
- [Commits](https://github.com/netlify/cli/compare/v9.13.0...v9.13.1 )
---
updated-dependencies:
- dependency-name: netlify-cli
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-15 04:11:11 +00:00
dependabot[bot]
dbc3d026d1
Bump sharp from 0.30.2 to 0.30.3
...
Bumps [sharp](https://github.com/lovell/sharp ) from 0.30.2 to 0.30.3.
- [Release notes](https://github.com/lovell/sharp/releases )
- [Changelog](https://github.com/lovell/sharp/blob/main/docs/changelog.md )
- [Commits](https://github.com/lovell/sharp/compare/v0.30.2...v0.30.3 )
---
updated-dependencies:
- dependency-name: sharp
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-15 04:03:49 +00:00
Nick Dower
0114dcda7f
Merge pull request #1998 from freesewing/i18n
...
New Crowdin updates
2022-03-14 11:02:56 +01:00
Nick Dower
0353ea5f36
Merge pull request #1997 from freesewing/dependabot/npm_and_yarn/packages/svgtopdf/lodash-4.17.21
...
Bump lodash from 4.17.15 to 4.17.21 in /packages/svgtopdf
2022-03-14 10:14:58 +01:00
Joost De Cock
d0f8ef7726
New translations workbench.yaml (Dutch)
2022-03-14 08:26:02 +01:00
Joost De Cock
158ae48889
New translations workbench.yaml (German)
2022-03-14 08:26:02 +01:00
Joost De Cock
9e68627f19
New translations workbench.yaml (Spanish)
2022-03-14 08:26:01 +01:00
Joost De Cock
cd1ee18a64
New translations workbench.yaml (French)
2022-03-14 08:25:59 +01:00
dependabot[bot]
fb144a9bdf
Bump lodash from 4.17.15 to 4.17.21 in /packages/svgtopdf
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.21 )
---
updated-dependencies:
- dependency-name: lodash
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-14 07:23:34 +00:00
Joost De Cock
643b50703b
Merge pull request #1995 from freesewing/joost/customlayout
...
feat: First stab at custom layout
2022-03-14 08:22:35 +01:00
Joost De Cock
c639f50a62
fix: Linter warnings
2022-03-13 17:29:22 +01:00
Joost De Cock
353f9cd1c3
fix(core): Added postLayout hook to tests
2022-03-13 15:01:28 +01:00
Joost De Cock
6a835ed7a9
Merge pull request #1996 from freesewing/joost/issue-1991
...
feat(charlie): Add notches to front pocket facing. Closes #1991
2022-03-13 14:58:13 +01:00
Joost De Cock
2b67932f31
fix(charlie): Removed unused shorthand object
2022-03-13 14:40:49 +01:00
Joost De Cock
10adb33402
fix(lab): Issues after linter fixes
2022-03-13 14:38:48 +01:00
Joost De Cock
9fc3752d8d
Update packages/freesewing.shared/components/workbench/layout/print/pagesize-picker.js
...
Co-authored-by: Nick Dower <nicholasdower@gmail.com>
2022-03-13 14:33:20 +01:00
Joost De Cock
9bb6dbe179
Update packages/freesewing.shared/components/workbench/layout/print/pagesize-picker.js
...
Co-authored-by: Nick Dower <nicholasdower@gmail.com>
2022-03-13 14:33:15 +01:00
Joost De Cock
a254baa747
Update packages/freesewing.shared/components/workbench/layout/draft.js
...
Co-authored-by: Nick Dower <nicholasdower@gmail.com>
2022-03-13 14:33:10 +01:00
Joost De Cock
74cf28b871
chore: Fixed linter warnings
2022-03-13 08:48:21 +01:00
Natalia Sayang
aea57ee872
Update contrib call date
2022-03-12 14:17:12 -05:00
Joost De Cock
818e5cc329
Merge pull request #1994 from freesewing/i18n
...
New Crowdin updates
2022-03-12 19:11:13 +01:00
Joost De Cock
b349765655
feat(charlie): Add notches to front pocket facing. Closes #1991
2022-03-12 19:10:00 +01:00
Joost De Cock
67da7dd595
feat(lab): First stab at custom layout
...
This adds a React component to handle custom layouts.
This React component is a long way from perfect, but it's a start.
There are two reasons that (at least in my opinion) implementing this is non-trivial:
1) React re-render vs DOM updates
For performance reasons, we can't re-render with React when the user drags a
pattern part (or rotates it). It would kill performance.
So, we don't re-render with React upon dragging/rotating, but instead manipulate
the DOM directly.
So far so good, but of course we don't want a pattern that's only correctly laid
out in the DOM. We want to updat the pattern gist so that the new layout is stored.
For this, we re-render with React on the end of the drag (or rotate).
Handling this balance between DOM updates and React re-renders is a first contributing
factor to why this component is non-trivial
2) SVG vs DOM coordinates
When we drag or rotate with the mouse, all the events are giving us coordinates of
where the mouse is in the DOM.
The layout uses coordinates from the embedded SVG which are completely different.
So we need to make this translation and that adds complexity.
3) Part-level transforms
It's not just that the DOM coordinates and SVG coordinate system is different, each
part also has it's own transforms applied and because of this behaves as if they have
their own coordinate system.
In other words, a point (0,0) in the part is not the top-left corner of the page.
In the best-case scenario, it's the top-left corner of the part. But even this is
often not the case as parts will have transforms applied to them.
4) Flip along X or Y axis
Parts can be flipped along the X or Y axis to facilitate a custom layout.
This is handled in a transform, so the part's coordinate's don't actually change. They
are flipped late into the rendering process (by the browser displaying the SVG).
Handling this adds yet more mental overhead
5) Bounding box
While moving and rotating parts around is one thing. Recalculating the bounding box
(think auto-cropping the pattern) gets kinda complicated because of the reasons
outlined above.
We are currently handling a lot in the frontend code. It might be more elegant to move
some of this to core. For example, core expects the custom layout to set the widht and height
rather than figuring it out on its own as it does for auto-generated layouts.
Known issues
- Rotating gets a little weird sometimes as the part rotates around it's center in the
SVG coordinate system, but the mouse uses it's own coordinates as the center point that's
used to calculate the angle of the rotation
- Moving parts into the negative space (minus X or Y coordinated) does not extend the bounding box.
- Rotation gets weird when a part is mirrored
- The bounding box update when a part is rotated is not entirely accurate
I've sort of left it at this because I'm starting to wonder if we should perhaps re-think
how custom layouts are supported in the core. And I would like to discuss this with the core team.
2022-03-12 18:54:47 +01:00
Joost De Cock
0545abe86c
New translations en.md (Dutch)
2022-03-12 12:25:34 +01:00
Joost De Cock
9d233b7b03
New translations en.md (German)
2022-03-12 12:25:33 +01:00
Joost De Cock
32c179ca8d
New translations en.md (Spanish)
2022-03-12 12:25:32 +01:00
Joost De Cock
a3390f3087
New translations en.md (French)
2022-03-12 12:25:31 +01:00
Joost De Cock
1d92db515d
Merge pull request #1990 from TriploidTree/patch-1
...
Making it more clear you need four pocket facings
2022-03-12 12:22:14 +01:00
Joost De Cock
4c707041da
chore: Update cutting instructions
...
Brackets to remove ambiguity
2022-03-12 12:21:55 +01:00
Joost De Cock
ff25ce43d2
Merge pull request #1993 from freesewing/i18n
...
New Crowdin updates
2022-03-12 12:19:15 +01:00
Joost De Cock
a179f1407a
New translations en.md (Dutch)
2022-03-12 01:36:03 +01:00
Joost De Cock
99a3d2aade
New translations en.md (Dutch)
2022-03-12 01:36:02 +01:00
Tríona
e085060044
Making it more clear you need four pocket facings
...
I cut two, not paying close attention and then halfway through construction realised I needed 2x2 = 4
2022-03-10 17:36:41 +00:00
Nick Dower
33d28176a2
Merge pull request #1989 from freesewing/dependabot/npm_and_yarn/netlify-cli-9.13.0
...
Bump netlify-cli from 9.12.3 to 9.13.0
2022-03-10 10:52:27 +01:00
dependabot[bot]
2ecfb380a7
Bump netlify-cli from 9.12.3 to 9.13.0
...
Bumps [netlify-cli](https://github.com/netlify/cli ) from 9.12.3 to 9.13.0.
- [Release notes](https://github.com/netlify/cli/releases )
- [Changelog](https://github.com/netlify/cli/blob/main/CHANGELOG.md )
- [Commits](https://github.com/netlify/cli/compare/v9.12.3...v9.13.0 )
---
updated-dependencies:
- dependency-name: netlify-cli
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-10 04:10:02 +00:00
Nick Dower
a810505a77
Merge pull request #1987 from freesewing/dependabot/npm_and_yarn/postcss-8.4.8
...
Bump postcss from 8.4.7 to 8.4.8
2022-03-09 10:19:33 +01:00
dependabot[bot]
0bc970c47e
Bump postcss from 8.4.7 to 8.4.8
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.7 to 8.4.8.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.7...8.4.8 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-09 10:09:27 +01:00
Nick Dower
51e959e66c
Merge pull request #1986 from freesewing/dependabot/npm_and_yarn/urijs-1.19.10
...
Bump urijs from 1.19.9 to 1.19.10
2022-03-09 09:57:25 +01:00
dependabot[bot]
0edbfbbf8c
Bump urijs from 1.19.9 to 1.19.10
...
Bumps [urijs](https://github.com/medialize/URI.js ) from 1.19.9 to 1.19.10.
- [Release notes](https://github.com/medialize/URI.js/releases )
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md )
- [Commits](https://github.com/medialize/URI.js/compare/v1.19.9...v1.19.10 )
---
updated-dependencies:
- dependency-name: urijs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-08 23:43:13 +00:00
Joost De Cock
4d2c43608f
Merge pull request #1984 from freesewing/i18n
...
New Crowdin updates
2022-03-07 18:09:56 +01:00
Joost De Cock
1fd07d4506
New translations en.md (Dutch)
2022-03-07 16:07:51 +01:00
Joost De Cock
6bd1dc9d32
New translations en.md (Dutch)
2022-03-07 15:58:45 +01:00