1
0
Fork 0
Commit graph

109638 commits

Author SHA1 Message Date
Natalia Sayang
e30abc4c6b Adds Carlita, Carlton, Cathrin line drawings 2024-02-11 02:04:41 +00:00
Joost De Cock
73c5844192 Update source file en.md
skip-build
2024-02-10 21:36:06 +01:00
Joost De Cock
c8ee9002f1 New translations en.md (Ukrainian)
skip-build
2024-02-10 21:33:46 +01:00
Joost De Cock
8685d5a3a7 New translations en.md (Dutch)
skip-build
2024-02-10 21:33:33 +01:00
Joost De Cock
684b71b071 New translations en.md (German)
skip-build
2024-02-10 21:33:31 +01:00
Joost De Cock
75d69da705 New translations en.md (Spanish)
skip-build
2024-02-10 21:33:30 +01:00
Joost De Cock
cfb24ebd34 New translations en.md (French)
skip-build
2024-02-10 21:33:28 +01:00
Joost De Cock
7404a830ff Update source file en.md
skip-build
2024-02-10 19:30:48 +01:00
Joost De Cock
2b8210bae4 Update source file en.md
skip-build
2024-02-10 19:30:48 +01:00
Joost De Cock
05c8e0e5f9 Update source file en.md
skip-build
2024-02-10 19:29:47 +01:00
Joost De Cock
2c8cd1f5b8 Update source file en.md
skip-build
2024-02-10 19:29:38 +01:00
Joost De Cock
0a83db17cd New translations en.md (Ukrainian)
skip-build
2024-02-10 19:02:10 +01:00
Joost De Cock
e760d58e54 New translations en.md (Ukrainian)
skip-build
2024-02-10 19:02:08 +01:00
Joost De Cock
ca4ec5bd12 New translations en.md (Ukrainian)
skip-build
2024-02-10 18:59:07 +01:00
Joost De Cock
0b9776a083 New translations en.md (Ukrainian)
skip-build
2024-02-10 18:58:38 +01:00
Joost De Cock
ab04b47468 New translations en.md (Dutch)
skip-build
2024-02-10 18:50:32 +01:00
Joost De Cock
ada80fc829 New translations en.md (Dutch)
skip-build
2024-02-10 18:49:43 +01:00
Joost De Cock
5ab25d9ce4 New translations en.md (Dutch)
skip-build
2024-02-10 18:49:38 +01:00
Joost De Cock
658b07c060 New translations en.md (Dutch)
skip-build
2024-02-10 18:49:36 +01:00
Joost De Cock
35d039a182 New translations en.md (Dutch)
skip-build
2024-02-10 18:49:30 +01:00
Joost De Cock
d3aa892c52 New translations en.md (Dutch)
skip-build
2024-02-10 18:49:20 +01:00
Joost De Cock
e70606fa99 New translations en.md (Dutch)
skip-build
2024-02-10 18:38:36 +01:00
Joost De Cock
c32eab6c27 New translations en.md (Dutch)
skip-build
2024-02-10 18:38:34 +01:00
Joost De Cock
52814bc3fd New translations en.md (Dutch)
skip-build
2024-02-10 18:35:41 +01:00
Joost De Cock
0cc127776c New translations en.md (Dutch)
skip-build
2024-02-10 18:35:12 +01:00
Joost De Cock
d2d061776b New translations en.md (German)
skip-build
2024-02-10 18:28:52 +01:00
Joost De Cock
9c9fab0e45 New translations en.md (German)
skip-build
2024-02-10 18:28:47 +01:00
Joost De Cock
c7de9f5143 New translations en.md (German)
skip-build
2024-02-10 18:28:45 +01:00
Joost De Cock
fa91a422b7 New translations en.md (German)
skip-build
2024-02-10 18:28:39 +01:00
Joost De Cock
932708a17a New translations en.md (German)
skip-build
2024-02-10 18:28:29 +01:00
Joost De Cock
64b02ea07e New translations en.md (German)
skip-build
2024-02-10 18:17:32 +01:00
Joost De Cock
41715a6ac3 New translations en.md (German)
skip-build
2024-02-10 18:17:30 +01:00
Joost De Cock
87a00dd736 New translations en.md (German)
skip-build
2024-02-10 18:14:29 +01:00
Joost De Cock
9bfbef60ef New translations en.md (German)
skip-build
2024-02-10 18:14:00 +01:00
Joost De Cock
a4c281b444 New translations en.md (Spanish)
skip-build
2024-02-10 18:07:44 +01:00
Joost De Cock
ad2ff5efa3 New translations en.md (Spanish)
skip-build
2024-02-10 18:07:40 +01:00
Joost De Cock
8c03b8ccd1 New translations en.md (Spanish)
skip-build
2024-02-10 18:07:35 +01:00
Joost De Cock
8251404583 New translations en.md (Spanish)
skip-build
2024-02-10 18:07:33 +01:00
Joost De Cock
40ee07ab35 New translations en.md (Spanish)
skip-build
2024-02-10 18:07:27 +01:00
Joost De Cock
1ae67df03c New translations en.md (Spanish)
skip-build
2024-02-10 18:07:17 +01:00
Joost De Cock
0c8ed7ddf1 New translations en.md (Spanish)
skip-build
2024-02-10 17:56:07 +01:00
Joost De Cock
7ccf2a0c12 New translations en.md (Spanish)
skip-build
2024-02-10 17:56:04 +01:00
Joost De Cock
db6fb29e3a
Merge pull request #6002 from freesewing/joost
fix(brian): Take biceps ease into account for armhole depth
2024-02-10 17:55:43 +01:00
Joost De Cock
f382bd5bb5 New translations en.md (Spanish)
skip-build
2024-02-10 17:53:10 +01:00
Joost De Cock
272b921073 New translations en.md (Spanish)
skip-build
2024-02-10 17:52:41 +01:00
Joost De Cock
6df53b1e47 New translations en.md (French)
skip-build
2024-02-10 17:46:12 +01:00
Joost De Cock
75b39fab33 New translations en.md (French)
skip-build
2024-02-10 17:46:10 +01:00
Joost De Cock
7ac8c4aea1 New translations en.md (French)
skip-build
2024-02-10 17:46:04 +01:00
Joost De Cock
75fb9f0d76 New translations en.md (French)
skip-build
2024-02-10 17:45:53 +01:00
joostdecock
91c5edb1aa fix(brian): Take biceps ease into account for armhole depth
Originally, #5999 was filed to report issues with the sleeve on Jaeger
not responding to biceps ease as expected. Increasing the biceps ease
would actually make the sleeve more narrow.

Turns out, this is a side-effect of the way the armhole depth is
calculated in v3. We used to take the biceps measurement (and ease) for
that, but now we rely on the waist to armpit measurements.

In brain, we used this new measurements along with the
armholeDepthFactor option to locate the bottom of the armhole.
This means that when we change the biceps ease, nothing will change in
the briam armhole, which means the total sleevecap length target remains
unchanges.
However, in Jaeger, increased biceps ease causes a taller sleevecap, and
since the total target sleevecap length (inherited from Brian) remains
unchanged, the pattern accomodates by making the sleeve more narrow so
that the taller sleevecap has the same sleevecap length. This is what
results in the counterintuitive behavior where increasing the biceps
ease makes the sleevecap more narrow.

This resolves that by taking the biceps ease into account when
calculating the bottom of the armhole in Brian. As a result, changing
the biceps ease will impact the armhole on Brian, which will in turn
influence the target sleevecap length that Bent drafts a 2-part sleeve
for, and now things work as aspected.

Given that Brian is such a foundational block, making changes to it is a
high-stakes game, but I feel this is a bug, so we need to fix it.

Fixes #5999
2024-02-10 17:38:57 +01:00